Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Component | Area: Different min height implementation #550

Merged
merged 4 commits into from
Apr 10, 2025

Conversation

rokotyan
Copy link
Contributor

@rokotyan rokotyan commented Apr 8, 2025

New minHeight config, deprecating minHeight1Px.

  • Introduced minHeight property for minimum area height, defaulting to undefined.
  • Updated area generation logic to accommodate new minHeight configuration.
  • Deprecated minHeight1Px in favor of minHeight for better clarity and functionality.

Dev Example

image

Updated Docs:

SCR-20250408-ijic

rokotyan added 2 commits April 8, 2025 08:52
- Introduced `minHeight` property for minimum area height, defaulting to undefined.
- Updated area generation logic to accommodate new `minHeight` configuration.
- Deprecated `minHeight1Px` in favor of `minHeight` for better clarity and functionality.
@lee00678 lee00678 requested a review from suryahanumandla April 9, 2025 21:32
If your data has small or zero values leading to some parts of the area to become invisible, you can force those area segments to have 1px height
despite their actual value by setting `minHeight1Px` to `true`. This can be useful if you want to visually emphasize that the data behind the chart
is defined but just very small.
If your data has small or zero values leading to some parts of the area to become invisible, you can use the `minHeight` property to set a minimum height for the area. This can be useful if you want to visually emphasize that the data behind the chart is defined but just very small.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to add a note there indicating we want to deprecate minHeight1px? Otherwise right now there's no mention on the website, just 2 examples right next to each other

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lee00678 I was thinking about it but decided not to (forgot to remove the example). The property will be marked as deprecated in the code asking users to use minHeight

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lee00678 I was thinking about it but decided not to (forgot to remove the example). The property will be marked as deprecated in the code asking users to use minHeight

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rokotyan I will remove the minHeight1px example then

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lee00678 Thanks

@lee00678
Copy link
Collaborator

lee00678 commented Apr 9, 2025

@rokotyan this looks good to me.

lee00678
lee00678 previously approved these changes Apr 9, 2025
- Revised the explanation of the `minHeight` property to clarify its purpose and usage.
- Added a note regarding the visual representation of data when using `minHeight` to ensure users understand its impact on the chart display.
@lee00678 lee00678 merged commit 7a6e8d4 into f5:main Apr 10, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants