-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Component | Area: Different min height implementation #550
Conversation
- Introduced `minHeight` property for minimum area height, defaulting to undefined. - Updated area generation logic to accommodate new `minHeight` configuration. - Deprecated `minHeight1Px` in favor of `minHeight` for better clarity and functionality.
If your data has small or zero values leading to some parts of the area to become invisible, you can force those area segments to have 1px height | ||
despite their actual value by setting `minHeight1Px` to `true`. This can be useful if you want to visually emphasize that the data behind the chart | ||
is defined but just very small. | ||
If your data has small or zero values leading to some parts of the area to become invisible, you can use the `minHeight` property to set a minimum height for the area. This can be useful if you want to visually emphasize that the data behind the chart is defined but just very small. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to add a note there indicating we want to deprecate minHeight1px
? Otherwise right now there's no mention on the website, just 2 examples right next to each other
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lee00678 I was thinking about it but decided not to (forgot to remove the example). The property will be marked as deprecated in the code asking users to use minHeight
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lee00678 I was thinking about it but decided not to (forgot to remove the example). The property will be marked as deprecated in the code asking users to use minHeight
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rokotyan I will remove the minHeight1px
example then
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lee00678 Thanks
@rokotyan this looks good to me. |
- Revised the explanation of the `minHeight` property to clarify its purpose and usage. - Added a note regarding the visual representation of data when using `minHeight` to ensure users understand its impact on the chart display.
9689d53
to
fc96812
Compare
New
minHeight
config, deprecatingminHeight1Px
.minHeight
property for minimum area height, defaulting to undefined.minHeight
configuration.minHeight1Px
in favor ofminHeight
for better clarity and functionality.Dev Example
Updated Docs: