Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libf3d: Fix a crash with ui.axis with external window #2123

Merged
merged 1 commit into from
Apr 7, 2025

Conversation

mwestphal
Copy link
Member

@mwestphal mwestphal commented Apr 7, 2025

  • Ensure Interactor is available before calling ShowAxis
  • Add a test in TestSDK

@mwestphal mwestphal requested a review from Meakk April 7, 2025 06:48
@mwestphal mwestphal force-pushed the libf3d_fix_axis_segfault branch from 02ddaf3 to 656e479 Compare April 7, 2025 06:49
Copy link

codecov bot commented Apr 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.91%. Comparing base (8d04b92) to head (656e479).
Report is 187 commits behind head on release.

Additional details and impacted files
@@             Coverage Diff             @@
##           release    #2123      +/-   ##
===========================================
+ Coverage    95.67%   95.91%   +0.24%     
===========================================
  Files          125      127       +2     
  Lines         9947    11098    +1151     
===========================================
+ Hits          9517    10645    +1128     
- Misses         430      453      +23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mwestphal mwestphal merged commit 82573c6 into f3d-app:release Apr 7, 2025
52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants