Skip to content

fix: color code parsing in theme.yml#1705

Open
zohnannor wants to merge 1 commit intoeza-community:mainfrom
zohnannor:fix-color-code-parsing
Open

fix: color code parsing in theme.yml#1705
zohnannor wants to merge 1 commit intoeza-community:mainfrom
zohnannor:fix-color-code-parsing

Conversation

@zohnannor
Copy link

@zohnannor zohnannor commented Jan 28, 2026

for whatever reason, when implemented in #1111, 'fixed' color was only able to be parsed from two-digit numbers (so, only 0 to 99 color codes were usable).


for this PR:

  • I'm not super familiar with conventional commits, sorry! would adding a : after fix be enough? 🙂
  • regarding CHANGELOG.md: I'm pretty sure this needs to be documented there... right?

@ariasuni
Copy link
Contributor

ariasuni commented Feb 3, 2026

You should rebase your commit on main instead of doing a merge, because it’s (apparently) forbidden by our CI. You could do that with an interactive rebase.

I'm not super familiar with conventional commits, sorry! would adding a : after fix be enough? 🙂

Yes, but also add «in theme.yaml» or something so we have a bit more context.

regarding CHANGELOG.md: I'm pretty sure this needs to be documented there... right?

We’ll do that later, just before doing the release.

@zohnannor
Copy link
Author

instead of doing a merge, because it’s (apparently) forbidden by our CI

Oh, that's unfortunate, I'm so used to squashing PR commits I didn't even think about it😅

No problem and thanks, will do once I'm at my computer again!

@zohnannor zohnannor force-pushed the fix-color-code-parsing branch 3 times, most recently from 6901041 to c73fb28 Compare February 3, 2026 13:04
allow 1- and 3-digit color codes
@zohnannor zohnannor force-pushed the fix-color-code-parsing branch from c73fb28 to ede0665 Compare February 3, 2026 13:07
@zohnannor zohnannor changed the title fix color code parsing @zohnannor fix: color code parsing in theme.yml Feb 3, 2026
@zohnannor zohnannor changed the title @zohnannor fix: color code parsing in theme.yml fix: color code parsing in theme.yml Feb 3, 2026
@zohnannor
Copy link
Author

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants