fix: color code parsing in theme.yml#1705
Open
zohnannor wants to merge 1 commit intoeza-community:mainfrom
Open
fix: color code parsing in theme.yml#1705zohnannor wants to merge 1 commit intoeza-community:mainfrom
zohnannor wants to merge 1 commit intoeza-community:mainfrom
Conversation
Contributor
|
You should rebase your commit on main instead of doing a merge, because it’s (apparently) forbidden by our CI. You could do that with an interactive rebase.
Yes, but also add «in theme.yaml» or something so we have a bit more context.
We’ll do that later, just before doing the release. |
Author
Oh, that's unfortunate, I'm so used to squashing PR commits I didn't even think about it😅 No problem and thanks, will do once I'm at my computer again! |
6901041 to
c73fb28
Compare
allow 1- and 3-digit color codes
c73fb28 to
ede0665
Compare
Author
|
done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
for whatever reason, when implemented in #1111, 'fixed' color was only able to be parsed from two-digit numbers (so, only 0 to 99 color codes were usable).
for this PR:
:afterfixbe enough? 🙂CHANGELOG.md: I'm pretty sure this needs to be documented there... right?