Skip to content

Conversation

@henryhchchc
Copy link

@henryhchchc henryhchchc commented Nov 6, 2025

Implement --hyperlink=auto/always/never. This enables eza to embed hyperlinks only when printing to a terminal.

Fixes #1093
Fixes #703

@henryhchchc henryhchchc requested a review from sseering November 28, 2025 01:44
@henryhchchc henryhchchc force-pushed the feat/hyperlink-when branch 2 times, most recently from 4710e58 to 4f8a98d Compare December 18, 2025 07:15
@henryhchchc
Copy link
Author

henryhchchc commented Dec 18, 2025

The test is obsolete

Fixed by 58b98cf

Details ``` eza> Testing tests/gen/long_time_style_relative_nix.toml ... failed 16ms 475us 986ns

eza> ---- expected: stdout
eza> ++++ actual: stdout
eza> 1 - drwxr-xr-x - nixbld 55 years git
eza> 2 - drwxr-xr-x - nixbld 55 years grid
eza> 3 - drwxr-xr-x - nixbld 55 years group
eza> 4 - drwxr-xr-x - nixbld 55 years icons
eza> 5 - drwxr-xr-x - nixbld 55 years perms
eza> 6 - drwxr-xr-x - nixbld 55 years size
eza> 7 - drwxr-xr-x - nixbld 55 years specials
eza> 8 - drwxr-xr-x - nixbld 55 years symlinks
eza> 9 - drwxr-xr-x - nixbld 55 years time
eza> 1 + drwxr-xr-x - nixbld 56 years git
eza> 2 + drwxr-xr-x - nixbld 56 years grid
eza> 3 + drwxr-xr-x - nixbld 56 years group
eza> 4 + drwxr-xr-x - nixbld 56 years icons
eza> 5 + drwxr-xr-x - nixbld 56 years perms
eza> 6 + drwxr-xr-x - nixbld 56 years size
eza> 7 + drwxr-xr-x - nixbld 56 years specials
eza> 8 + drwxr-xr-x - nixbld 56 years symlinks
eza> 9 + drwxr-xr-x - nixbld 56 years time
eza> stderr:


</details> 

@henryhchchc
Copy link
Author

I think the issues are addressed and the tests are passing now. Would appreciate your reviews! @sseering @MartinFillon @PThorpe92 @gierens @cafkafk

@dontdieych
Copy link

Oh, this is why I couldn't use eza and had to use ls instead. I'm looking forward to it. 👍

Copy link
Contributor

@MartinFillon MartinFillon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi thanks for the pr, this looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

4 participants