Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(themes): allow custom animations on popups #352

Merged
merged 10 commits into from
Jan 17, 2025

Conversation

luriusTM
Copy link
Contributor

@luriusTM luriusTM commented Dec 12, 2024

  • Open tooltip on volume change in media center
  • Scrollability on volume controls
  • Percent description on volume notifier
Screen.Recording.2024-12-12.121854.mp4
  • Popup appear styleability
  • Popup disappear styleability
    Current simplest style applied
Screen.Recording.2024-12-12.122111.mp4

Animation possibilities (weg):

Screen.Recording.2024-12-12.130124.mp4

Animation possibilities (tb):

Screen.Recording.2024-12-12.130236.mp4

@eythaann
Copy link
Owner

Will be merged to v2.1, but disabling motion on the root config also disable animation on buttons, context menu and any other antd component? (it doesn't matter because all these will be replaced by self components latter but try it to know)

@luriusTM
Copy link
Contributor Author

Will be merged to v2.1, but disabling motion on the root config also disable animation on buttons, context menu and any other antd component? (it doesn't matter because all these will be replaced by self components latter but try it to know)

It is hard to say what does it change for a button or slider... because it does not have too much animation... but this setting centrally removes all antd animation for the current scope (tb, weg). It removes from dropdown, that is for sure, it has same root appearance animation like popovers, also removes the minimal from tooltips. For calendar view it does not have any animation,

Will replace the dropdown animation also then.

@luriusTM luriusTM force-pushed the feature/usability-fixies branch from 4240109 to de32efd Compare December 13, 2024 10:23
@luriusTM
Copy link
Contributor Author

  • merged the master
  • added context menus for the scope
  • fixed context menu for launcher

pre:
image
post:
image

@luriusTM luriusTM force-pushed the feature/usability-fixies branch from de32efd to 0b05b28 Compare December 20, 2024 14:36
@luriusTM luriusTM force-pushed the feature/usability-fixies branch from 0b05b28 to d745ec8 Compare January 2, 2025 02:54
@eythaann eythaann changed the title Minor usability and styleability improvements. feat(themes): allow custom animations on popups Jan 7, 2025
@eythaann eythaann merged commit 39ca955 into eythaann:master Jan 17, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants