Skip to content

Conversation

@eylles
Copy link
Owner

@eylles eylles commented Mar 29, 2022

PR #541

@threadreaper colors.hs being exported with a capital C is still needed right?

@threadreaper
Copy link
Contributor

Honestly I've worked on so many things since I worked on this I'll have to find time to go through it all again to answer your question with confidence, but I'm inclined to say that if it wasn't needed I would have eliminated it when I worked on this in the past. I will have some time later today to take a deeper look.

@eylles
Copy link
Owner Author

eylles commented Mar 30, 2022

I will assume the lack of response means yes and will merge in some hours.

@eylles eylles merged commit b473c5a into master Mar 30, 2022
@threadreaper
Copy link
Contributor

Sorry, I got tied up. Got a lot going on with work right now. Honestly, I remember contributing to this project, but I believe what I added was a patch for changing the wallpaper on KDE Plasma after some updates to it broke that functionality. I had to google to even find out what haskell was. I generally try and add fairly detailed commit notes as well and I don't see any. I'm not sure how this got associated with me, but I don't think this was my work.

@eylles eylles deleted the haskell_support branch January 28, 2024 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants