Fix confusing option deprecation messages

expressjs · Jul 4, 2014 · 2b969b6 · 2b969b6
1 parent 61e5e6b
commit 2b969b6
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/History.md b/History.md
@@ -1,3 +1,8 @@
+unreleased
+==========
+
+  * Fix confusing option deprecation messages
+
 1.6.1 / 2014-06-28
 ==================
 

diff --git a/index.js b/index.js
@@ -83,12 +83,12 @@ function session(options){
   }
 
   if (resaveSession === undefined) {
-    deprecate('pass resave option; default value will change');
+    deprecate('undefined resaveSession option; provide resave option');
     resaveSession = true;
   }
 
   if (saveUninitializedSession === undefined) {
-    deprecate('pass saveUninitialized option; default value will change');
+    deprecate('undefined saveUninitialized option; provide saveUninitialized option');
     saveUninitializedSession = true;
   }
 
@@ -116,7 +116,7 @@ function session(options){
   store.on('connect', function(){ storeReady = true; });
 
   if (!options.secret) {
-    deprecate('pass secret option; do not use req.secret');
+    deprecate('req.secret; provide secret option');
   }
 
   return function session(req, res, next) {