Skip to content

New Crowdin Translations #1874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: gh-pages
Choose a base branch
from
Open

New Crowdin Translations #1874

wants to merge 3 commits into from

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Apr 14, 2025

New Crowdin translations by Crowdin GH Action

Important

Here's a reset of several existing translations. Crowdin can't translate everything correctly, so there won't be many translations coming from Crowdin

Important

For @expressjs/docs-wg, do not merge until the project on Crowdin is public.

@github-actions github-actions bot requested review from a team as code owners April 14, 2025 22:43
Copy link

netlify bot commented Apr 14, 2025

Deploy Preview for expressjscom-preview ready!

Name Link
🔨 Latest commit fb714ab
🔍 Latest deploy log https://app.netlify.com/projects/expressjscom-preview/deploys/682be27872d7b70009431df9
😎 Deploy Preview https://deploy-preview-1874--expressjscom-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@bjohansebas
Copy link
Member

Okay, I still haven't managed to prevent certain front matter elements (like layout) from being translated and to exclude redirect_from from the import. I'll keep investigating tomorrow.

@github-actions github-actions bot force-pushed the l10n branch 5 times, most recently from 4aea850 to 564c666 Compare April 15, 2025 16:10
@bjohansebas
Copy link
Member

Okay, I'm almost done solving most of the issues.

@github-actions github-actions bot force-pushed the l10n branch 4 times, most recently from bc92504 to bd45f22 Compare April 17, 2025 02:50
@ShubhamOulkar
Copy link
Member

WatchingEyesGIF

@github-actions github-actions bot force-pushed the l10n branch 10 times, most recently from c134168 to 70c8a01 Compare April 27, 2025 17:12
@github-actions github-actions bot force-pushed the l10n branch 3 times, most recently from 92a0027 to 6995b89 Compare May 2, 2025 00:06
@carlosstenzel
Copy link
Contributor

I thought we wouldn't have language subfolders anymore :/

@bjohansebas
Copy link
Member

Okay, it looks like the change worked. This weekend, I’ll remove all the languages that won’t be on the site.

@ctcpip could you make the Crowdin project public? Also, I think you need to assign me a new role in Crowdin so I can approve new translators for the project. I think the closest fit would be for me to be a manager of the project, since I’ll also need permissions to edit certain Crowdin configurations.

@ctcpip
Copy link
Member

ctcpip commented May 8, 2025

The project can't be public unless we configure crowdsourcing.

@ShubhamOulkar
Copy link
Member

The project can't be public unless we configure crowdsourcing.

Yes, Setting translation goals in crowdsourcing is important.

@github-actions github-actions bot force-pushed the l10n branch 4 times, most recently from 0ec922c to c834bc1 Compare May 10, 2025 22:17
bjohansebas
bjohansebas previously approved these changes May 10, 2025
@bjohansebas bjohansebas dismissed their stale review May 10, 2025 22:54

We're not uploading index.md to Crowdin, so that part is missing for this PR to be ready. It's just that small detail, so if I could get some reviews on this (#1899) , that would be great

@bjohansebas
Copy link
Member

I was going to make the changes again so they could be reviewed, but there's a blog post in progress that will be published today, so once it's published, the changes will be reverted again.

Copy link
Member

@bjohansebas bjohansebas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bjohansebas
Copy link
Member

Important

For @expressjs/docs-wg, do not merge until the project on Crowdin is public.

@bjohansebas
Copy link
Member

i have brought back my changes that I had locally, since only a blog post was added there are no conflicts, and these are the same ones that were previously reviewed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants