-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New Crowdin Translations #1874
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: gh-pages
Are you sure you want to change the base?
New Crowdin Translations #1874
Conversation
✅ Deploy Preview for expressjscom-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Okay, I still haven't managed to prevent certain front matter elements (like layout) from being translated and to exclude redirect_from from the import. I'll keep investigating tomorrow. |
4aea850
to
564c666
Compare
Okay, I'm almost done solving most of the issues. |
bc92504
to
bd45f22
Compare
c134168
to
70c8a01
Compare
92a0027
to
6995b89
Compare
I thought we wouldn't have language subfolders anymore :/ |
Okay, it looks like the change worked. This weekend, I’ll remove all the languages that won’t be on the site. @ctcpip could you make the Crowdin project public? Also, I think you need to assign me a new role in Crowdin so I can approve new translators for the project. I think the closest fit would be for me to be a manager of the project, since I’ll also need permissions to edit certain Crowdin configurations. |
The project can't be public unless we configure crowdsourcing. |
Yes, Setting translation goals in crowdsourcing is important. |
0ec922c
to
c834bc1
Compare
We're not uploading index.md to Crowdin, so that part is missing for this PR to be ready. It's just that small detail, so if I could get some reviews on this (#1899) , that would be great
I was going to make the changes again so they could be reviewed, but there's a blog post in progress that will be published today, so once it's published, the changes will be reverted again. |
Signed-off-by: Sebastian Beltran <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Important For @expressjs/docs-wg, do not merge until the project on Crowdin is public. |
i have brought back my changes that I had locally, since only a blog post was added there are no conflicts, and these are the same ones that were previously reviewed |
New Crowdin translations by Crowdin GH Action
Important
Here's a reset of several existing translations. Crowdin can't translate everything correctly, so there won't be many translations coming from Crowdin
Important
For @expressjs/docs-wg, do not merge until the project on Crowdin is public.