Skip to content

separate content of headers and footer #1769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 6, 2025

Conversation

bjohansebas
Copy link
Member

@bjohansebas bjohansebas commented Feb 6, 2025

related #1768

This PR is not designed to completely separate the content from the layout, I will finish the work in another PR

@bjohansebas bjohansebas requested review from a team as code owners February 6, 2025 02:34
@bjohansebas bjohansebas marked this pull request as draft February 6, 2025 02:34
Copy link

netlify bot commented Feb 6, 2025

Deploy Preview for expressjscom-preview ready!

Name Link
🔨 Latest commit 444b783
🔍 Latest deploy log https://app.netlify.com/sites/expressjscom-preview/deploys/67a43788a1a2fb00080e2847
😎 Deploy Preview https://deploy-preview-1769--expressjscom-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@bjohansebas bjohansebas added i18n maintenance Issues/PRs related to making the website maintainable labels Feb 6, 2025
@bjohansebas bjohansebas force-pushed the separate-content-of-layout branch from 066693e to 4625c61 Compare February 6, 2025 02:39
@bjohansebas bjohansebas force-pushed the separate-content-of-layout branch from 5df2ef0 to c78422e Compare February 6, 2025 02:57
@bjohansebas bjohansebas changed the title separate content of headers separate content of headers and footer Feb 6, 2025
@bjohansebas bjohansebas marked this pull request as ready for review February 6, 2025 04:06
Copy link
Contributor

@carlosstenzel carlosstenzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 😊

@bjohansebas bjohansebas merged commit d94613a into gh-pages Feb 6, 2025
8 checks passed
@bjohansebas bjohansebas deleted the separate-content-of-layout branch February 6, 2025 23:13
chrisdel101 pushed a commit to chrisdel101/expressjs.com that referenced this pull request Feb 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
i18n maintenance Issues/PRs related to making the website maintainable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants