Skip to content

Separate the content of the layout #1768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bjohansebas opened this issue Feb 5, 2025 · 3 comments · Fixed by #1930
Closed

Separate the content of the layout #1768

bjohansebas opened this issue Feb 5, 2025 · 3 comments · Fixed by #1930
Labels
design Change, update, or fix for site UI (not content) good first issue Issues for newcomers i18n maintenance Issues/PRs related to making the website maintainable

Comments

@bjohansebas
Copy link
Member

We need to separate the content of the layout (menu, footer). Part of the idea from #1738 can be used, but we need Jekyll to generate it instead of modifying the content after the page loads. This is necessary to achieve #1676.

@bjohansebas bjohansebas added design Change, update, or fix for site UI (not content) i18n maintenance Issues/PRs related to making the website maintainable labels Feb 5, 2025
@bjohansebas bjohansebas self-assigned this Feb 5, 2025
@bjohansebas
Copy link
Member Author

bjohansebas commented Feb 6, 2025

https://github.com/untra/polyglot I have found this plugin, it is probably a good option

edit: we don't need that plugin, I already found an elegant way to do it

@bjohansebas
Copy link
Member Author

The only thing left is to move the i18n-alert (https://github.com/expressjs/expressjs.com/tree/gh-pages/_includes/notice)

Example: #1784

@bjohansebas bjohansebas removed their assignment May 28, 2025
@bjohansebas
Copy link
Member Author

@expressjs/docs-wg, can someone make the final effort, or maybe a new contributor?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design Change, update, or fix for site UI (not content) good first issue Issues for newcomers i18n maintenance Issues/PRs related to making the website maintainable
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant