Make ast.Node return *nature.Nature #849
                
     Merged
            
            
          
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Fix #839
We keep using
nature.Natureinstead of*nature.Natureinside ofast.basebecause this reduces the number of checks and makes the implementation safer. Also, we always assume that we will have a nature, and the zero value of a nature is also useful, so no need to ever returnnil.@antonmedv this actually resulted in a minor performance improvement in several places and it also makes code more readable as you suggested 😃
Checker benchmarks