feat: add @expo/entity-testing-utils package #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #280 +/- ##
===========================================
- Coverage 100.00% 99.68% -0.32%
===========================================
Files 88 81 -7
Lines 2417 2192 -225
Branches 285 241 -44
===========================================
- Hits 2417 2185 -232
- Misses 0 7 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
wschurman
force-pushed
the
@wschurman/04-07-feat_add_expo/entity-testing-utils_package
branch
2 times, most recently
from
b64fd88 to
98eef2d
Compare
wschurman
force-pushed
the
@wschurman/04-07-feat_add_expo/entity-testing-utils_package
branch
from
98eef2d to
adf1c53
Compare
quinlanj
approved these changes
Apr 8, 2025
sjchmiela
approved these changes
Apr 9, 2025
wschurman
deleted the
@wschurman/04-07-feat_add_expo/entity-testing-utils_package
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
When testing the last batch of changes in the Expo server, I noticed that I needed to use the TSMockitoExtensions. Figured it was a good idea to expose them for others to use as well.
How
The challenge is that these should only be in dev dependencies so exposing them in the @expo/entity package is a no-go.
So, create a new package. Then, it made sense to move all the testing utilities to that package. But this requires duplicating code since it would create a dependency cycle if entity used the common code in addition to the common code using entity. So, the solution is to make the test utils depend on entity but not vice-versa and just duplicate the modules. Then, add a test to ensure the duplicated modules stay perfectly in-sync.
This also moves the other test utilities into this new package.
Test Plan
Run all tests (full coverage).