chore: bump minimum required Node version to 18.14.0
#2420
+5
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
byCedric
requested review from
szdziedzic,
khamilowicz and
sjchmiela
as code owners
|
Size Change: +1.38 kB (0%) Total Size: 53.4 MB
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2420 +/- ##
=======================================
Coverage 52.47% 52.47%
=======================================
Files 584 584
Lines 22627 22627
Branches 4465 4465
=======================================
Hits 11872 11872
Misses 10721 10721
Partials 34 34 ☔ View full report in Codecov by Sentry. |
szdziedzic
approved these changes
Jun 12, 2024
khamilowicz
approved these changes
Oct 3, 2024
byCedric
force-pushed
the
@bycedric/bump-to-node-18-13
branch
from
fc227c4 to
c58bd36
Compare
|
Subscribed to pull request
Generated by CodeMention |
byCedric
changed the title
18.13.018.14.0
This version includes the `File` primitive that might be required for FormData and large file uploads. See: https://nodejs.org/en/blog/release/v18.13.0\#introduce-file See: https://github.com/expo/eas-cli/pull/2414\#discussion_r1634640527
byCedric
force-pushed
the
@bycedric/bump-to-node-18-13
branch
from
c58bd36 to
ebe6848
Compare
|
✅ Thank you for adding the changelog entry! |
|
I bumped the minimum required version to Node 18.14 - seems to be a bug in the This PR will unblock the Undici migration, following the workaround in #2414 (comment) Rebasing that PR onto this one for testing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
This version includes the
Fileprimitive that might be required for FormData and large file uploads.See: https://nodejs.org/en/blog/release/v18.13.0#introduce-file
See: #2414 (comment)
How
Bumped all
engines: node: >=18.0.0toengines: node: >=18.14.0Test Plan
Only a package change.