Sql explorer save query params

[dwmorrison33]

Description

This provides the functionality to save query params so that the queries execute with them each time one comes to the Query Detail page.

Deployment Procedures

• Migration (Please specify app(s) below)
  • ./manage.py migrate explorer

Tests

Execute Manual UI Tests like the following:

1. Create a new query with a query param and save, note the same functionality exists as previously where the query does not execute due to no value for the new param:

2. Input a value for the parameter and save:

3. Now add a new parameter and save:

4. Now save a new value to the second parameter:

5. Now navigate back to the Query List page and click on the test query:

6. Validate that the new QueryParams persist and the query executed:

Also, you will want to verify that the csv and JSON exports still work correctly like:

[dwmorrison33]

@marksweb Thank you for the instructions here: #482 (comment) They were very helpful and I learned a couple new things.

[marksweb]

@dwmorrison33 You're welcome. I'll take a look over this.

First thing that I notice is the inclusion of unicode_literals. Are you using python 2 still? If you are, you should move to python 3.

[dwmorrison33]

@dwmorrison33 You're welcome. I'll take a look over this.

First thing that I notice is the inclusion of unicode_literals. Are you using python 2 still? If you are, you should move to python 3.

@marksweb Im not sure why that was auto generated since I am on Python3 and these code changes were tested against python3.7 and django1.11

[marksweb]

@dwmorrison33 So just trying to understand this, because as I said, I don't use query params in my queries.

If a query parameter ends up as a database object linked to the query - why not just put the value into the query and have different queries for however many values you need? Because I'm just thinking about efficiency. If there is value in having the query parameters in the database, I'd maybe have done a JSON field so all the params with a query go into 1 object.

[dwmorrison33]

@dwmorrison33 So just trying to understand this, because as I said, I don't use query params in my queries.

If a query parameter ends up as a database object linked to the query - why not just put the value into the query and have different queries for however many values you need? Because I'm just thinking about efficiency. If there is value in having the query parameters in the database, I'd maybe have done a JSON field so all the params with a query go into 1 object.

@marksweb I thought about doing it that way, however chose not to since JSONField is database dependent. IIRC, the use of JSONField is specific to Postgres databases and not usable by MySQL, Oracle, etc.. I would think since there are only 2 queries performed in the create_query_params, it should be performant enough for this use case.

[dwmorrison33]

If a query parameter ends up as a database object linked to the query - why not just put the value into the query and have different queries for however many values you need?

@marksweb I just realized that I did not respond to the first question you asked and the reason why we wouldnt want that is because we have roughly 1000 queries and that could become cumbersome to save a bunch of the same queries with different values. The desired behavior is that we can store the query parameters for users who are not experienced with writing SQL and would not have to update values directly, as well as so that after one navigates away from the Query Detail and then comes back that the params would persist for the next user who is looking at that Query Detail.

[dwmorrison33]

Closing in favor of #489