-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added playwright support and passed the tests #1376
base: main
Are you sure you want to change the base?
added playwright support and passed the tests #1376
Conversation
Nice! Want to create a NB illustrating some examples? |
one question - suppose a person installs without screenshots - is there an appropriate pip command they can use later to install or do they just re-install generally? It would be nice if when a user tries to use, say, screenshot, we say "Oh, to use this, run..." |
Creating a notebook, So when they use screenshots without the dependencies the error will prompt them to run "pip install edsl[screenshot]" |
Nice!
|
I'm using VScode's Notebook mode, resolved all the errors there. Let me try in Jupyter to see if things are breaking. Did you find any issues while running this brach yet? Cool, will check out ScenarioList. Also it just incurred that the |
syncing the updates
This reverts commit a2f94b5.
You can install this by either:
poetry install --extras "screenshot"
or
pip install -e ".[screenshot]"
You run this by:
from edsl import FileStore
fs = FileStore.from_url_screenshot("https://www.expectedparrot.com")
fs.view()
I was not sure whether I should commit the poetry.lock file, please feel free to ignore that file.