Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Elm Analyzer comments for concept exercise tisbury-treasure-hunt #2294

Merged
merged 1 commit into from
Nov 10, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
# use placeLocationToTreasureLocation

Please use `placeLocationToTreasureLocation` in `treasureLocationMatchesPlaceLocation`, as reusing functions helps with maintainability.
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
# use tuple in case

Like the instructions mention, when defining `specialCaseSwapPossible` you should use a `case` statement on a tuple with the three values of interest and pattern match on the combinations that allow swapping.
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
# use tuple second

You will find that `Tuple.second` is very well suited for defining `countPlaceTreasures`, you can map it on the list of treasures or use it in a `List.filter` function.
Try it out!