Add Elm Analyzer comment for concept exercise valentines-day
#2286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
track/elm
ceddlyburge
approved these changes
Oct 30, 2023
|
@exercism/reviewers can I have an approval please? 💛 |
ee7
previously approved these changes
Oct 30, 2023
There was a problem hiding this comment.
LGTM.
If you want the nitpick: maybe consider changing the filename to:
use_case_statement.md
and the header to
# use case statementThat avoids a potential misreading of "use case" as a noun, such as "x is a good use case for doing y", rather than "use" as a verb.
kotp
previously approved these changes
Oct 30, 2023
|
Thanks for the nitpick @ee7, I'll take it. |
ErikSchierboom
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sister PR here.
@ceddlyburge can you take a look?