Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[java/rational-numbers] Create mentoring.md #2207

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions tracks/java/exercises/rational-numbers/mentoring.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
The tolerance (DOUBLE_EQUALITY_TOLERANCE) is too small for the unit test testRaiseARealNumberToAPositiveRationalNumber().
The calculation of exp() is too numerically sensitive to whether the user implements
```
Math.pow(Math.pow(x, numerator), 1.0/denominator)
```
or
```
Math.pow(Math.pow(x, 1.0/denominator), numerator)
```
Both are mathematically equivalent, however, the first one fails the unit test whereas the second passes.
Furthermore, the instructions to the exercise bias the user towards the first implementation.