Skip to content

Conversation

@senekor
Copy link
Contributor

@senekor senekor commented Feb 25, 2025

The test files were renamed to use snake case in:
exercism/rust#2036

The test files were renamed to use snake case in:
exercism/rust#2036
@senekor senekor requested a review from a team as a code owner February 25, 2025 12:44
@github-actions
Copy link

Hello 👋 Thanks for your PR.

This repo does not currently have dedicated maintainers. Our guardians team will attempt to review and merge your PR, but it will likely take longer for your PR to be reviewed.

If you enjoy contributing to Exercism and have a track-record of doing so successfully, you might like to become an Exercism maintainer for this track.

Please feel free to ask any questions, or chat to us about anything to do with this PR or the reviewing process on the Exercism forum.

(cc @exercism/guardians)

@senekor
Copy link
Contributor Author

senekor commented Feb 25, 2025

@senekor
Copy link
Contributor Author

senekor commented Feb 25, 2025

This is not caught by the tests, because the tests actually read the slug from the test file name. And the existing two_plus_two actually was already snake case.

I don't think it's worth it to try to change the tests so they can detect future regressions like this, I see no reason the test file names would be changed again.

@senekor senekor merged commit 7fe0e7a into main Feb 27, 2025
3 checks passed
@senekor senekor deleted the senekor/yxsxxukvuvtv branch February 27, 2025 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants