-
-
Notifications
You must be signed in to change notification settings - Fork 623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dates Concept Exercise (Library Fees) #1787
base: main
Are you sure you want to change the base?
Conversation
Dear JaPatGitHubThank you for contributing to the JavaScript track on Exercism! 💙
Dear Reviewer/Maintainer
Automated comment created by PR Commenter 🤖. |
@junedev , @SleeplessByte just a reminder |
@JaPatGitHub Sorry for the delay, we were both busy. I have time again in the coming days. I will respond to your question as soon as possible. |
@JaPatGitHub Great work on the story/tasks! With the last task I am not sure whether it will add anything really related to handling dates in the end. If not, maybe you can combine 4 and 5 into one task where the students needs to check for Monday and calculate the late fee so the story has a nice ending. One more general comment regarding the instructions: After the header for an individual task and the story sentence, there should be a sentence that is very clear on what function to write and what inputs and outputs it has. See
This is also described in the docs for concept exercises: https://exercism.org/docs/building/tracks/concept-exercises#h-file-docs-instructions-md |
@JaPatGitHub Are you still working on this? |
I'm sorry @SleeplessByte , I didn't notice @junedev 's reply in my last PR which I was waiting for. I'll start working on it right away. |
@junedev , should I close this PR? Or do I just make the modifications you previously suggested so that who works next on this can use this story... |
@JaPatGitHub yes, let's not throwaway your hard work and author credit. If you could make those suggestions that'd be great. If not, that's also okay, then we stash it somewhere so the next person can continue. |
@junedev, I just wanted to ensure with you if the story in
.docs/instructions.md
file is okay. If it is, I will move forward writing the spec, test and other docs files