Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing redirecting paths with duplicate code #2888

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

jagdish-15
Copy link
Contributor

@jagdish-15 jagdish-15 commented Dec 30, 2024

Pull Request

Screenshot 2024-12-31 021926

This changed redirecting paths in "Calculator Conundrum" and other exercises with duplicate code. This comes after the conversation in this pull request


Reviewer Resources:

Track Policies

@jagdish-15
Copy link
Contributor Author

.\gradlew check
PS C:\Programming\Exercism\java\exercises> .\gradlew check

BUILD SUCCESSFUL in 6s
888 actionable tasks: 888 up-to-date

All the checks are successful in the local tests but lint checks are failing here, what could be the reason?

@kahgoh
Copy link
Member

kahgoh commented Jan 1, 2025

Hey @jagdish-15, are you using Github desktop by any chance? Looking on Google, I came across this: desktop/desktop#14937

I've just tried checking out your branch. Interestingly, when run file .meta/src/reference/java/Character it says:

.meta/src/reference/java/Character.java: broken symbolic link to public class Character

I think you could try telling Git to delete the redirection file first (on the Git command line, run git rm <file to file>) and then add the copy after.

@jagdish-15
Copy link
Contributor Author

No, I am not using the GitHub desktop!

But I'll try using the remove file and then add a copy afterwards.

@jagdish-15
Copy link
Contributor Author

@kahgoh, the method of initially removing the files and then adding a copy of theirs worked; now, the PR passes all the tests.

I appreciate your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants