Update RationalTest.java #2886
Update RationalTest.java #2886
Conversation
Fixed the bug in (exercism#2823) issue
|
This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested. If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos. For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping |
|
| @@ -11,7 +11,7 @@ public class RationalTest { | |||
| private static final double DOUBLE_EQUALITY_TOLERANCE = 1e-15; | |||
|
|
|||
| private void assertDoublesEqual(double x, double y) { | |||
| assertThat(x).isEqualTo(y, within(DOUBLE_EQUALITY_TOLERANCE)); | |||
| assertThat(x, closeTo(y, within (DOUBLE_EQUALITY_TOLERANCE)); | |||
There was a problem hiding this comment.
Looking at the AssertJ examples, I was wondering if this is what you meant?
| assertThat(x, closeTo(y, within (DOUBLE_EQUALITY_TOLERANCE)); | |
| assertThat(x).isCloseTo(y, within(DOUBLE_EQUALITY_TOLERANCE)); |
Otherwise this doesn't compile:
/home/runner/work/java/java/exercises/practice/rational-numbers/src/test/java/RationalTest.java:14: error: ')' expected
> Task :practice:rational-numbers:compileStarterSourceJava
assertThat(x, closeTo(y, within (DOUBLE_EQUALITY_TOLERANCE));
Correct the error I previously made in (exercism#2886) no important files changed
|
Yes this is what I meant to write. I opened another pull request (#2887) and I uploaded the corrected code |
Fixes (#2823)
Now the testRaiseARealNumberToAPositiveRationalNumber() test gets passed.
pull request
Reviewer Resources:
Track Policies