Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write constants in UPPER_CASE #2884

Merged
merged 1 commit into from
Dec 30, 2024
Merged

Write constants in UPPER_CASE #2884

merged 1 commit into from
Dec 30, 2024

Conversation

josealonso
Copy link
Contributor

Fix constants casing in the functional approach for the Darts exercise

Reviewer Resources:

Track Policies

@josealonso josealonso mentioned this pull request Dec 28, 2024
Closed
@josealonso josealonso marked this pull request as ready for review December 28, 2024 17:26
@josealonso
Copy link
Contributor Author

@kahgoh, let me know if I'm missing something.
Thanks :)

kahgoh
kahgoh approved these changes Dec 30, 2024
View reviewed changes
Copy link
Member

@kahgoh kahgoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for raising this PR! I agree with the changes here, as I think it is more idiomatic to use SCREAMING_CASE for static constants and to write private static final instead of final private static.

@kahgoh kahgoh merged commit ea11011 into exercism:main Dec 30, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kahgoh kahgoh kahgoh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josealonso @kahgoh