Fix test name for binary search exercise #2883
Conversation
|
This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested. If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos. For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping |
| @@ -119,7 +119,7 @@ public void nothingIsFoundInAnEmptyArray() throws ValueNotFoundException { | |||
| @Disabled("Remove to run test") | |||
| @Test | |||
| public void nothingIsFoundWhenTheLeftAndRightBoundCross() throws ValueNotFoundException { | |||
| List<Integer> sortedList = List.of(1, 2); | |||
| List<Integer> sortedList = List.of(2, 1); | |||
There was a problem hiding this comment.
I can revert this again, but the test name suggests to me that right boundary (maximum) is less than the left boundary (minimum).
There was a problem hiding this comment.
Hey @akmaekki, the data for the tests comes from the problem specifications. As far as I can tell, the List.of(1, 2) matches the problem specification and so does the name. I think the name may be referring to way binary search works - left and right starts at the end and beginning of the list. At each step, compare the value you're looking for and update the "left" and "right" indexes depending on the comparison result. Repeat. If the value isn't in the list, the "left" and "right" will eventually cross over. Although, I'm little unsure why the value 0 is chosen as the value to find - it looks like the same case as aValueSmallerThanTheArraysSmallestValueIsNotFound.
If you feel there is still something wrong with the data for this test and would like to change, could you please open a discussion in the forums? Generally, we should fix the data in the problem specifications so that it can eventually be fixed in all tracks with this exercise, but we usually discuss changes to the problem specifications in the forums first.
The change to the other test method is fine because the change still matches the problem specifications. For this PR, I'd suggest backing this out for now to unblock it. If we agree to fix it in the forums, we can also do another PR.
There was a problem hiding this comment.
Hi @kahgoh
Thanks for the elaborate discussion and tip with the forum. I am fine with backing this out. Will remove the changes done on nothingIsFoundWhenTheLeftAndRightBoundCross and refresh this PR.
kahgoh
changed the title
2881
In JAVA track improve test names for binary search exercise.
Fixes #2881
Reviewer Resources:
Track Policies