Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Binary Search Exercise: Fix test name #2881

Closed
akmaekki opened this issue Dec 27, 2024 · 2 comments · Fixed by #2883
Closed

Binary Search Exercise: Fix test name #2881

akmaekki opened this issue Dec 27, 2024 · 2 comments · Fixed by #2883

Comments

@akmaekki
Copy link
Contributor

The test name aValueLargerThanTheArraysSmallestValueIsNotFound should be changed to aValueLargerThanTheArraysLargestValueIsNotFound, because the value 13 to be tested is larger than the arrays largest value 11.

@kahgoh
Copy link
Member

kahgoh commented Dec 28, 2024

@akmaekki good spotting! You're right, the test is named incorrectly. Would you like to fix the test's name? You would only need to update the test in exercises/practice/binary-search/src/test/java/BinarySearchTest.java.

@akmaekki
Copy link
Contributor Author

@kahgoh
Sure, will fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants