-
-
Notifications
You must be signed in to change notification settings - Fork 9
Add track installation instructions #97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
codingthat
wants to merge
6
commits into
exercism:main
Choose a base branch
from
codingthat:add-installation
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
8fd6f0b
Add track installation instructions
codingthat 07cdb3c
Inline refs and single-sentence-per-line
codingthat 444cd35
Include test setup instructions
codingthat 107e961
Add clarifications:
codingthat 47b1f52
Merge branch 'exercism:main' into add-installation
codingthat c82456f
Fix exercism workspace location
codingthat File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,15 +1,15 @@ | ||
| # Installation | ||
|
|
||
| <!-- TODO: write document | ||
| ## Installing Godot Engine | ||
|
|
||
| This document should describe what the student needs to install | ||
| to allow working on the track on their local system using the CLI. | ||
| The GDScript track is built on top of [Godot Engine](https://godotengine.org/), which runs on Windows, Linux, macOS, and Android. This track requires Godot version 4.0 or greater. | ||
|
|
||
| You can include the installation instructions in this document, but | ||
| usually it is better to link to a resource with the official installation | ||
| instructions, to prevent the instructions from becoming outdated. | ||
| After completing the installation, you can verify if the CLI was installed successfully by running this command in a terminal: | ||
|
|
||
| The contents of this document are displayed on the track's documentation | ||
| page at `https://exercism.org/docs/tracks/<track>/installation`. | ||
| ```bash | ||
| godot --version | ||
| ``` | ||
|
|
||
| See https://exercism.org/docs/building/tracks/docs for more information. --> | ||
| ## Using an IDE | ||
|
|
||
| For syntax checking of GDScript files from, for example, [Visual Studio Code](https://code.visualstudio.com/download), you'll need to keep the Godot GUI running with a project open in order to activate the debug server, and an extension like [godot-tools](https://open-vsx.org/vscode/item?itemName=geequlim.godot-tools) installed and activated. | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The idea here is that these should be instructions to setup the language for local testing. If it is meant that users should be using docker for testing then these docs should describe how to setup that for different os.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure it's about testing, per se — there's both docs/TESTS.md and exercises/shared/.docs/tests.md for that, hence my WIP branch for those.
The spec and example for this docs/INSTALLATION.md seem to point more to just installing Godot itself, no?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is supposed to tell you how to install so you can test the tests locally.
I mean in most cases, say Python. You would install Python and then you could install the library needed and then simply run
pytestand you would get the output. And some languages doesn't need any dependencies at all and have everything built in. So for Godot, if you need like a bash script for it to work. Then these instructions should tell you how to install that script for example.Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, fair enough — but then what goes in
TESTS.mdfor Godot? Should it just point back toINSTALLATION.mdbecause there's nothing else to say like other tracks might (skipped tests, etc.)? Or duplicate its info (doesn't sound ideal, but then again, there's explicit mention of doing that for resources vs. help)?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So the difference between installation and tests is that installation says what/how you install to tests. But tests say how you test. So for python would that be something like:
INSTALLATION.md:
TESTS.md:
How to test e.g:
Find the folder with the exercise then
cdinto that folderThen you have to call
pytest.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, so, I will (once we agree on how the testing scripts should look, and finish them) move my WIP stuff so most of it is in this file. However, I'm not sure that's the correct move, because then there's not a real distinction between TESTS.md and the shared tests.md.
Here's what seemed to jive with the general track info docs as well as the comments in the templates:
And actually it's interesting you use Python as an example, because https://exercism.org/docs/tracks/python/installation is not at all about testing. Then its TESTS.md says e.g. how to install pytest. (Then I assume its shared tests.md it how to run tests for a single local exercise.)
However, it does seem that the "how to run a test" part is duplicated from the shared tests.md to the overall TESTS.md.
Either way, I think I did do the non-test installation instructions correctly in the end. OK to merge the current PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@meatball133 when you have a moment, let me know if this part is OK. Thanks!! :)