-
-
Notifications
You must be signed in to change notification settings - Fork 8
[New Exercise]: Hamming #60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
glaxxie
wants to merge
1
commit into
exercism:main
Choose a base branch
from
glaxxie:gdscript_hamming
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
# Instructions | ||
|
||
Calculate the Hamming Distance between two DNA strands. | ||
|
||
Your body is made up of cells that contain DNA. | ||
Those cells regularly wear out and need replacing, which they achieve by dividing into daughter cells. | ||
In fact, the average human body experiences about 10 quadrillion cell divisions in a lifetime! | ||
|
||
When cells divide, their DNA replicates too. | ||
Sometimes during this process mistakes happen and single pieces of DNA get encoded with the incorrect information. | ||
If we compare two strands of DNA and count the differences between them we can see how many mistakes occurred. | ||
This is known as the "Hamming Distance". | ||
|
||
We read DNA using the letters C,A,G and T. | ||
Two strands might look like this: | ||
|
||
GAGCCTACTAACGGGAT | ||
CATCGTAATGACGGCCT | ||
^ ^ ^ ^ ^ ^^ | ||
|
||
They have 7 differences, and therefore the Hamming Distance is 7. | ||
|
||
The Hamming Distance is useful for lots of things in science, not just biology, so it's a nice phrase to be familiar with :) | ||
|
||
## Implementation notes | ||
|
||
The Hamming distance is only defined for sequences of equal length, so an attempt to calculate it between sequences of different lengths should not work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
{ | ||
"authors": [ | ||
"glaxxie" | ||
], | ||
"files": { | ||
"solution": [ | ||
"hamming.gd" | ||
], | ||
"test": [ | ||
"hamming_test.gd" | ||
], | ||
"example": [ | ||
".meta/example.gd" | ||
] | ||
}, | ||
"blurb": "Calculate the Hamming difference between two DNA strands.", | ||
"source": "The Calculating Point Mutations problem at Rosalind", | ||
"source_url": "https://rosalind.info/problems/hamm/" | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
func distance(strand_1, strand_2): | ||
var dist = 0 | ||
for i in range(len(strand_1)): | ||
if strand_1[i] != strand_2[i]: | ||
dist += 1 | ||
return dist |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,67 @@ | ||
# This is an auto-generated file. | ||
# | ||
# Regenerating this file via `configlet sync` will: | ||
# - Recreate every `description` key/value pair | ||
# - Recreate every `reimplements` key/value pair, where they exist in problem-specifications | ||
# - Remove any `include = true` key/value pair (an omitted `include` key implies inclusion) | ||
# - Preserve any other key/value pair | ||
# | ||
# As user-added comments (using the # character) will be removed when this file | ||
# is regenerated, comments can be added via a `comment` key. | ||
|
||
[f6dcb64f-03b0-4b60-81b1-3c9dbf47e887] | ||
description = "empty strands" | ||
|
||
[54681314-eee2-439a-9db0-b0636c656156] | ||
description = "single letter identical strands" | ||
|
||
[294479a3-a4c8-478f-8d63-6209815a827b] | ||
description = "single letter different strands" | ||
|
||
[9aed5f34-5693-4344-9b31-40c692fb5592] | ||
description = "long identical strands" | ||
|
||
[cd2273a5-c576-46c8-a52b-dee251c3e6e5] | ||
description = "long different strands" | ||
|
||
[919f8ef0-b767-4d1b-8516-6379d07fcb28] | ||
description = "disallow first strand longer" | ||
include = false | ||
|
||
[b9228bb1-465f-4141-b40f-1f99812de5a8] | ||
description = "disallow first strand longer" | ||
reimplements = "919f8ef0-b767-4d1b-8516-6379d07fcb28" | ||
|
||
[8a2d4ed0-ead5-4fdd-924d-27c4cf56e60e] | ||
description = "disallow second strand longer" | ||
include = false | ||
|
||
[dab38838-26bb-4fff-acbe-3b0a9bfeba2d] | ||
description = "disallow second strand longer" | ||
reimplements = "8a2d4ed0-ead5-4fdd-924d-27c4cf56e60e" | ||
|
||
[5dce058b-28d4-4ca7-aa64-adfe4e17784c] | ||
description = "disallow left empty strand" | ||
include = false | ||
|
||
[db92e77e-7c72-499d-8fe6-9354d2bfd504] | ||
description = "disallow left empty strand" | ||
include = false | ||
reimplements = "5dce058b-28d4-4ca7-aa64-adfe4e17784c" | ||
|
||
[b764d47c-83ff-4de2-ab10-6cfe4b15c0f3] | ||
description = "disallow empty first strand" | ||
reimplements = "db92e77e-7c72-499d-8fe6-9354d2bfd504" | ||
|
||
[38826d4b-16fb-4639-ac3e-ba027dec8b5f] | ||
description = "disallow right empty strand" | ||
include = false | ||
|
||
[920cd6e3-18f4-4143-b6b8-74270bb8f8a3] | ||
description = "disallow right empty strand" | ||
include = false | ||
reimplements = "38826d4b-16fb-4639-ac3e-ba027dec8b5f" | ||
|
||
[9ab9262f-3521-4191-81f5-0ed184a5aa89] | ||
description = "disallow empty second strand" | ||
reimplements = "920cd6e3-18f4-4143-b6b8-74270bb8f8a3" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
func distance(strand_1, strand_2): | ||
pass |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
func test_empty_strands(solution_script): | ||
var values = ["", ""] | ||
var expected = 0 | ||
return [solution_script.distance(values[0], values[1]), expected] | ||
|
||
|
||
func test_single_letter_identical_strands(solution_script): | ||
var values = ["A", "A"] | ||
var expected = 0 | ||
return [solution_script.distance(values[0], values[1]), expected] | ||
|
||
|
||
func test_single_letter_different_strands(solution_script): | ||
var values = ["G", "T"] | ||
var expected = 1 | ||
return [solution_script.distance(values[0], values[1]), expected] | ||
|
||
|
||
func test_long_identical_strands(solution_script): | ||
var values = ["GGACTGAAATCTG", "GGACTGAAATCTG"] | ||
var expected = 0 | ||
return [solution_script.distance(values[0], values[1]), expected] | ||
|
||
|
||
func test_long_different_strands(solution_script): | ||
var values = ["GGACGGATTCTG", "AGGACGGATTCT"] | ||
var expected = 9 | ||
return [solution_script.distance(values[0], values[1]), expected] | ||
|
||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More tests are present here than exist in the test suite. Unimplemented tests should be marked with include = false underneath.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh. I thought that if the first one has
Include = false
then the re-implementation will be default as not included as well. I didn't know we have to mark them all. Gonna fix it.Edit: On a second thought, let just wait for pfertyk, if he wants to forgone these then I will just mark them as
include = false
, else I will add them and returnnull
. This PR should be merged last in the chain anyway.