-
-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set track to active #86
Conversation
I can't reopen a force-pushed PR, sorry |
I'd prefer to launch with the icon. @iHiD is this something you can do? |
@ErikSchierboom my bad, I used rebase to update the branch instead of merge.
|
Icon added and merged: exercism/website-icons#177 |
I've just added the track to the database, which means that maintainers (which includes you) can now access the track at https://exercism.org/tracks/cairo Before launching, I'd like some other maintainers to look at the track and test it. The way we usually do this is that you (the person that created the track) open a post on the forum (https://forum.exercism.org/) asking maintainers to help test the track. That said, before doing that you should get a working test runner, which we require before launching a track. There is a repo, but it doesn't yet do anything: https://github.com/exercism/cairo-test-runner If you need help, let me know. |
@ErikSchierboom opening the post and starting work on the test runner! |
Implemented the test runner exercism/cairo-test-runner#3 |
Sorry, I think I might have explained it badly. What I would like to see is a separate PR to enable the test runner, which can then be merged without setting the track to active. This will allow maintainers to pre-test the track (and the test runner) before being launched. |
This reverts commit 85f1736.
@ErikSchierboom ah, now I understand. Removed test-runner changes from this PR and creating a new PR #97 to just enable it. |
@ErikSchierboom should a PR also be created for https://github.com/exercism/cli/blob/main/workspace/test_configurations.go#L63? |
That would be great! |
@ErikSchierboom created relevant PRs: Let me know if I need to do change something in the PRs |
The Cairo test runner has been deployed: https://github.com/exercism/cairo-test-runner/actions/runs/10057739306/job/27799348315 |
@ErikSchierboom yes I did http://forum.exercism.org/t/need-maintainers-to-test-the-new-cairo-track/12154 Not much interest from other maintainers though |
@ErikSchierboom EDIT: I really don't understand what happened here. I recommitted this change ee04052, now I can access the online editor. |
@ErikSchierboom do you know why there's no code highlight in the online editor? It should be the same as Rust's, I set |
That's different, the online editor uses CodeMirror. Highlightjs is used for all non-interactive code snippets. |
@ErikSchierboom merged all the requested changes (by maintainers), are we good enough to launch? |
Go for it! |
Here we goooo |
Closes #75, Closes #82
@ErikSchierboom @iHiD wasn't sure what does the launch process look exactly, so created this PR for you to approve once it should be launched. Please let me know if I should contact somebody else regarding this.
I created a request to add Cairo logos, but they have not yet been added:
exercism/website-icons#176
Does this preclude launching or can we launch regardless?