Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set track to active #86

Merged
merged 3 commits into from
Jul 26, 2024
Merged

Set track to active #86

merged 3 commits into from
Jul 26, 2024

Conversation

0xNeshi
Copy link
Contributor

@0xNeshi 0xNeshi commented Jul 15, 2024

Closes #75, Closes #82

@ErikSchierboom @iHiD wasn't sure what does the launch process look exactly, so created this PR for you to approve once it should be launched. Please let me know if I should contact somebody else regarding this.

I created a request to add Cairo logos, but they have not yet been added:
exercism/website-icons#176
Does this preclude launching or can we launch regardless?

@0xNeshi 0xNeshi requested review from ErikSchierboom and iHiD July 15, 2024 15:53
@0xNeshi 0xNeshi self-assigned this Jul 15, 2024
@0xNeshi 0xNeshi closed this Jul 16, 2024
@ErikSchierboom
Copy link
Member

I can't reopen a force-pushed PR, sorry

@ErikSchierboom
Copy link
Member

I created a request to add Cairo logos, but they have not yet been added:
exercism/website-icons#176
Does this preclude launching or can we launch regardless?

I'd prefer to launch with the icon. @iHiD is this something you can do?

@0xNeshi 0xNeshi mentioned this pull request Jul 16, 2024
@0xNeshi
Copy link
Contributor Author

0xNeshi commented Jul 16, 2024

@ErikSchierboom my bad, I used rebase to update the branch instead of merge.

Opened a new PR #88 Reopened this to avoid further confusion

@0xNeshi 0xNeshi reopened this Jul 16, 2024
@ErikSchierboom
Copy link
Member

Icon added and merged: exercism/website-icons#177

@ErikSchierboom
Copy link
Member

I've just added the track to the database, which means that maintainers (which includes you) can now access the track at https://exercism.org/tracks/cairo Before launching, I'd like some other maintainers to look at the track and test it. The way we usually do this is that you (the person that created the track) open a post on the forum (https://forum.exercism.org/) asking maintainers to help test the track.

That said, before doing that you should get a working test runner, which we require before launching a track. There is a repo, but it doesn't yet do anything: https://github.com/exercism/cairo-test-runner If you need help, let me know.

@0xNeshi
Copy link
Contributor Author

0xNeshi commented Jul 17, 2024

@ErikSchierboom opening the post and starting work on the test runner!

@0xNeshi
Copy link
Contributor Author

0xNeshi commented Jul 22, 2024

Implemented the test runner exercism/cairo-test-runner#3

@ErikSchierboom
Copy link
Member

Sorry, I think I might have explained it badly. What I would like to see is a separate PR to enable the test runner, which can then be merged without setting the track to active. This will allow maintainers to pre-test the track (and the test runner) before being launched.
The test runner will start working once exercism/terraform#117 is merged, so you'll also have to wait for that.

This reverts commit 85f1736.
@0xNeshi
Copy link
Contributor Author

0xNeshi commented Jul 23, 2024

@ErikSchierboom ah, now I understand. Removed test-runner changes from this PR and creating a new PR #97 to just enable it.

@0xNeshi
Copy link
Contributor Author

0xNeshi commented Jul 23, 2024

@ErikSchierboom
Copy link
Member

@ErikSchierboom should a PR also be created for https://github.com/exercism/cli/blob/main/workspace/test_configurations.go#L63?

That would be great!
And a snippet extractor PR: https://github.com/exercism/snippet-extractor
And a lines of code counter PR: https://github.com/exercism/lines-of-code-counter (which will also require a PR to https://github.com/exercism/tokei, like https://github.com/exercism/tokei/pull/17/files)

@0xNeshi
Copy link
Contributor Author

0xNeshi commented Jul 23, 2024

@ErikSchierboom created relevant PRs:
exercism/tokei#18
exercism/lines-of-code-counter#204
exercism/cli#1151
exercism/snippet-extractor#108 <-- this one you already merged

Let me know if I need to do change something in the PRs

@ErikSchierboom
Copy link
Member

The Cairo test runner has been deployed: https://github.com/exercism/cairo-test-runner/actions/runs/10057739306/job/27799348315
I don't remember if you did this, but I would recommend opening an issue on the Exercism forum requesting maintainers to try out the track (basically, getting feedback).

@0xNeshi
Copy link
Contributor Author

0xNeshi commented Jul 23, 2024

@ErikSchierboom yes I did http://forum.exercism.org/t/need-maintainers-to-test-the-new-cairo-track/12154

Not much interest from other maintainers though

@0xNeshi
Copy link
Contributor Author

0xNeshi commented Jul 23, 2024

@ErikSchierboom why is the track not yet available in the online editor? Is there something else I need to implement?
image

EDIT:
It seems the problem was that the commit that enabled the test runner was never actually merged into main
image

I really don't understand what happened here. I recommitted this change ee04052, now I can access the online editor.

@0xNeshi
Copy link
Contributor Author

0xNeshi commented Jul 24, 2024

@ErikSchierboom do you know why there's no code highlight in the online editor?
image

It should be the same as Rust's, I set "highlightjs_language": "rust" in the config.json.

@ErikSchierboom
Copy link
Member

That's different, the online editor uses CodeMirror. Highlightjs is used for all non-interactive code snippets.

@0xNeshi
Copy link
Contributor Author

0xNeshi commented Jul 26, 2024

@ErikSchierboom merged all the requested changes (by maintainers), are we good enough to launch?

@ErikSchierboom
Copy link
Member

Go for it!

@0xNeshi 0xNeshi merged commit cc605c2 into main Jul 26, 2024
4 checks passed
@0xNeshi 0xNeshi deleted the launch branch July 26, 2024 19:55
@0xNeshi
Copy link
Contributor Author

0xNeshi commented Jul 26, 2024

Here we goooo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Launch! Prepare for launch
2 participants