Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync change exercise #672

Merged
merged 1 commit into from
Mar 28, 2024
Merged

sync change exercise #672

merged 1 commit into from
Mar 28, 2024

Conversation

glennj
Copy link
Contributor

@glennj glennj commented Mar 28, 2024

No description provided.

@glennj glennj added the x:rep/small Small amount of reputation label Mar 28, 2024
Copy link

This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested.

If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.

[no important files changed]

For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping @exercism/maintainers-admin in a comment. Thank you!

@glennj glennj requested a review from a team March 28, 2024 14:23
@glennj
Copy link
Contributor Author

glennj commented Mar 28, 2024

adds an edge case that is not worth rerunning all tests for

I'd say this applies

Although it's not a high impact to rerun:
image

@IsaacG
Copy link
Member

IsaacG commented Mar 28, 2024

This checks for faulty algorithms. I would think rerunning tests would be wanted here.

@glennj glennj merged commit 8107b0b into exercism:main Mar 28, 2024
3 checks passed
@glennj glennj deleted the sync-change branch July 11, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
x:rep/small Small amount of reputation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants