Skip to content

Commit

Permalink
[#978] Add type info for exit/enter viewport events to actors (#1017)
Browse files Browse the repository at this point in the history
Closes #978

## Changes:

- No behavioral changes, just surfaces type info for events that currently need to be handled more "manually". Let me know if this still needs a CHANGELOG entry.
  • Loading branch information
alanag13 authored and eonarheim committed Jul 20, 2018
1 parent 50aab71 commit 4f8569e
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 1 deletion.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@ This project adheres to [Semantic Versioning](http://semver.org/).

### Fixed

- Fixed missing `exitviewport/enterviewport` events on Actors.on/once/off signatures. ([#978](https://github.com/excaliburjs/Excalibur/issues/978))

<!--------------------------------- DO NOT EDIT BELOW THIS LINE --------------------------------->

## [0.17.0] - 2018-06-04
Expand Down
10 changes: 9 additions & 1 deletion src/engine/Actor.ts
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,9 @@ import {
PreKillEvent,
GameEvent,
ExitTriggerEvent,
EnterTriggerEvent
EnterTriggerEvent,
EnterViewPortEvent,
ExitViewPortEvent
} from './Events';
import { PointerEvent, WheelEvent, PointerDragEvent } from './Input/Pointer';
import { Engine } from './Engine';
Expand Down Expand Up @@ -662,6 +664,8 @@ export class ActorImpl extends Class implements IActionable, IEvented, IPointerE
public on(eventName: Events.pointerdragenter, handler: (event?: PointerDragEvent) => void): void;
public on(eventName: Events.pointerdragleave, handler: (event?: PointerDragEvent) => void): void;
public on(eventName: Events.pointerdragmove, handler: (event?: PointerDragEvent) => void): void;
public on(eventName: Events.enterviewport, handler: (event?: EnterViewPortEvent) => void): void;
public on(eventName: Events.exitviewport, handler: (event?: ExitViewPortEvent) => void): void;
public on(eventName: string, handler: (event?: GameEvent<any>) => void): void;
public on(eventName: string, handler: (event?: any) => void): void {
this._checkForPointerOptIn(eventName);
Expand Down Expand Up @@ -727,6 +731,8 @@ export class ActorImpl extends Class implements IActionable, IEvented, IPointerE
public once(eventName: Events.pointerdragenter, handler: (event?: PointerDragEvent) => void): void;
public once(eventName: Events.pointerdragleave, handler: (event?: PointerDragEvent) => void): void;
public once(eventName: Events.pointerdragmove, handler: (event?: PointerDragEvent) => void): void;
public once(eventName: Events.enterviewport, handler: (event?: EnterViewPortEvent) => void): void;
public once(eventName: Events.exitviewport, handler: (event?: ExitViewPortEvent) => void): void;
public once(eventName: string, handler: (event?: GameEvent<any>) => void): void;
public once(eventName: string, handler: (event?: any) => void): void {
this._checkForPointerOptIn(eventName);
Expand Down Expand Up @@ -789,6 +795,8 @@ export class ActorImpl extends Class implements IActionable, IEvented, IPointerE
public off(eventName: Events.preupdate, handler?: (event?: Events.PreUpdateEvent) => void): void;
public off(eventName: Events.postdraw, handler?: (event?: Events.PostDrawEvent) => void): void;
public off(eventName: Events.predraw, handler?: (event?: Events.PreDrawEvent) => void): void;
public off(eventName: Events.enterviewport, handler?: (event?: EnterViewPortEvent) => void): void;
public off(eventName: Events.exitviewport, handler?: (event?: ExitViewPortEvent) => void): void;
public off(eventName: string, handler?: (event?: GameEvent<any>) => void): void;
public off(eventName: string, handler?: (event?: any) => void): void {
super.off(eventName, handler);
Expand Down

0 comments on commit 4f8569e

Please sign in to comment.