fix: collision crash, guard invalid separation

excaliburjs · Dec 18, 2024 · 3277026 · 3277026
1 parent 31305c5
commit 3277026
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -19,7 +19,7 @@ This project adheres to [Semantic Versioning](http://semver.org/).
 
 ### Fixed
 
--
+- Fixed CollidePolygonPolygon crash with some defense against invalid separation
 
 ### Updates
 

diff --git a/src/engine/Collision/Colliders/CollisionJumpTable.ts b/src/engine/Collision/Colliders/CollisionJumpTable.ts
@@ -253,6 +253,10 @@ export const CollisionJumpTable = {
       }
     }
 
+    if (!separation.localSide || !separation.localAxis || !separation.axis) {
+      return [];
+    }
+
     // Clip incident side by the perpendicular lines at each end of the reference side
     // https://en.wikipedia.org/wiki/Sutherland%E2%80%93Hodgman_algorithm
     const referenceSide = separation.localSide.transform(toIncidentFrame);
-Original file line number
+Diff line change
@@ Expand Up @@
     ### Fixed
-    -
+    - Fixed CollidePolygonPolygon crash with some defense against invalid separation
     ### Updates
@@ Expand Down @@