Remove xtensor argument #55
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
-fno-relaxed-template-template-argsargument that was added as a stopgap in #52. This was being used to fix a problem in xtensor and LLVM 19. The current build of LLVM (LLVM 21) doesn't need this argument to work anymore -- and also has removed this argument so gives an error if it is passed (it had been deprecated for awhile).This PR will cause OpenMC to no longer work with LLVM19 -- however, once xtensor-stack/xtensor#2821 is merged in to xtensor we can just update to that xtensor version to get OpenMC working again with LLVM 19. It is better not to wait until that is merged so that CI testing of the nightly LLVM build can continue. Those wanting to build the GPU offloading version of OpenMC specifically with LLVM 19 can just add the argument back in in the interim, though hopefully the xtensor fix will get merged soon.