Test data

manifests/info.pp

@@ -20,7 +20,7 @@
 define puppi::info (
   String $description  = '',
   String $templatefile = 'puppi/info.erb',
-  String $run          = '',
+  Variant[String,Array] $run = '',
 ) {
   require puppi
   require puppi::params

spec/classes/puppi_spec.rb2

@@ -0,0 +1,17 @@
+require 'spec_helper'
+
+describe 'puppi' do
+
+  let(:node) { 'rspec.example42.com' }
+  let(:node) { 'rspec.example42.com' }
+  let(:facts) { { :ipaddress => '10.42.42.42' } }
+
+  describe 'Test standard installation' do
+    it { should contain_file('puppi').with_ensure('present') }
+    it { should contain_file('puppi.conf').with_ensure('present') }
+    it { should contain_file('puppi.scripts').with_ensure('present') }
+    it { should contain_file('puppi_basedir').with_ensure('directory') }
+    it { should contain_file('puppi_datadir').with_ensure('directory') }
+  end
+
+end

spec/defines/check_spec.rb

@@ -3,32 +3,31 @@
 require 'spec_helper'
 
 describe 'puppi::check' do
-  let(:title) { 'puppi::check' }
-  let(:node) { 'rspec.example42.com' }
-  let(:pre_condition) { 'include puppi' }
-  let(:params) {
-    { 'enable'   =>  'true',
-      'name'     =>  'get',
-      'command'  =>  'echo',
-      'priority' =>  '50',
-      'project'  =>  'myapp',
-    }
-  }
 
-  describe 'Test puppi check step file creation' do
-    it 'should create a puppi::check step file' do
-      should contain_file('Puppi_check_myapp_50_get').with_ensure('present')
-    end
-    it 'should populate correctly the puppi::check step file' do
-      should contain_file('Puppi_check_myapp_50_get').with_content(/\/usr\/lib64\/nagios\/plugins\/echo/)
-    end
-  end
-
-  on_supported_os.select { |k, _v| k == 'redhat-8-x86_64'  }.each do |os, os_facts|
+    on_supported_os.select { |k, _v| k == 'redhat-8-x86_64'  }.each do |os, os_facts|
     context "on #{os}" do
-      let(:facts) { os_facts }
-
+      let(:facts) { os_facts }  
+      let(:title) { 'puppi::check' }
+      let(:node) { 'rspec.example42.com' }
+      let(:pre_condition) { 'include puppi' }
+      let(:params) {
+        { 'enable'   =>  'true',
+          'name'     =>  'get',
+          'command'  =>  'echo',
+          'priority' =>  '50',
+          'project'  =>  'myapp',
+        }
+      }
       it { is_expected.to compile }
+      describe 'Test puppi check step file creation' do
+        it 'should create a puppi::check step file' do
+          should contain_file('Puppi_check_myapp_50_get').with_ensure('present')
+        end
+        it 'should populate correctly the puppi::check step file' do
+          should contain_file('Puppi_check_myapp_50_get').with_content(/\/usr\/lib64\/nagios\/plugins\/echo/)
+        end
+      end
+
     end
   end
 end

spec/defines/configure_spec.rb

@@ -3,17 +3,16 @@
 require 'spec_helper'
 
 describe 'puppi::configure' do
-  let(:title) { 'namevar' }
-  let(:node) { 'rspec.example42.com' }
-  let(:pre_condition) { 'include puppi' }
-  let(:params) do
-    {}
-  end
 
   on_supported_os.select { |k, _v| k == 'redhat-8-x86_64'  }.each do |os, os_facts|
     context "on #{os}" do
       let(:facts) { os_facts }
-
+      let(:title) { 'namevar' }
+      let(:node) { 'rspec.example42.com' }
+      let(:pre_condition) { 'include puppi' }
+      let(:params) do
+        {}
+      end
       it { is_expected.to compile }
     end
   end

spec/defines/deploy_spec.rb

@@ -3,30 +3,29 @@
 require 'spec_helper'
 
 describe 'puppi::deploy' do
-  let(:title) { 'puppi::deploy' }
-  let(:node) { 'rspec.example42.com' }
-  let(:pre_condition) { 'include puppi' }
-  let(:params) {
-    { 'enable'   =>  'true',
-      'name'     =>  'get',
-      'command'  =>  'echo',
-      'priority' =>  '50',
-      'project'  =>  'myapp',
-    }
-  }
-
-  describe 'Test puppi deploy step file creation' do
-    it 'should create a puppi::deploy step file' do
-      should contain_file('/etc/puppi/projects/myapp/deploy/50-get').with_ensure('present')
-    end
-    it 'should populate correctly the puppi::deploy step file' do
-      should contain_file('/etc/puppi/projects/myapp/deploy/50-get').with_content("su - root -c \"export project=myapp && /etc/puppi/scripts/echo \"\n")
-    end
-  end
-
   on_supported_os.select { |k, _v| k == 'redhat-8-x86_64'  }.each do |os, os_facts|
     context "on #{os}" do
       let(:facts) { os_facts }
+      let(:title) { 'puppi::deploy' }
+      let(:node) { 'rspec.example42.com' }
+      let(:pre_condition) { 'include puppi' }
+      let(:params) {
+        { 'enable'   =>  'true',
+          'name'     =>  'get',
+          'command'  =>  'echo',
+          'priority' =>  '50',
+          'project'  =>  'myapp',
+        }
+      }
+
+      describe 'Test puppi deploy step file creation' do
+        it 'should create a puppi::deploy step file' do
+          should contain_file('/etc/puppi/projects/myapp/deploy/50-get').with_ensure('present')
+        end
+        it 'should populate correctly the puppi::deploy step file' do
+          should contain_file('/etc/puppi/projects/myapp/deploy/50-get').with_content("su - root -c \"export project=myapp && /etc/puppi/scripts/echo \"\n")
+        end
+      end
 
       it { is_expected.to compile }
     end

spec/defines/helper_spec.rb

@@ -3,26 +3,24 @@
 require 'spec_helper'
 
 describe 'puppi::helper' do
-  let(:title) { 'spec' }
-  let(:node) { 'rspec.example42.com' }
-  let(:pre_condition) { 'include puppi' }
-  let(:params) {
-    { 'template'   => 'puppi/helpers/standard.yml.erb'  }
-  }
-
-  describe 'Test puppi helper file creation' do
-    it 'should create a puppi helper file' do
-      should contain_file('puppi_helper_spec').with_ensure('present')
-    end
-    it 'should populate correctly the helper file' do
-      should contain_file('puppi_helper_spec').with_content(/info/)
-    end
-  end
-
   on_supported_os.select { |k, _v| k == 'redhat-8-x86_64'  }.each do |os, os_facts|
     context "on #{os}" do
       let(:facts) { os_facts }
-
+      let(:title) { 'spec' }
+      let(:node) { 'rspec.example42.com' }
+      let(:pre_condition) { 'include puppi' }
+      let(:params) {
+        { 'template'   => 'puppi/helpers/standard.yml.erb'  }
+      }
+
+      describe 'Test puppi helper file creation' do
+        it 'should create a puppi helper file' do
+          should contain_file('puppi_helper_spec').with_ensure('present')
+        end
+        it 'should populate correctly the helper file' do
+          should contain_file('puppi_helper_spec').with_content(/info/)
+        end
+      end
       it { is_expected.to compile }
     end
   end

spec/defines/info_spec.rb

@@ -3,30 +3,28 @@
 require 'spec_helper'
 
 describe 'puppi::info' do
-  let(:title) { 'puppi::info' }
-  let(:node) { 'rspec.example42.com' }
-  let(:pre_condition) { 'include puppi' }
-  let(:params) {
-    { 'name'         =>  'sample',
-      'description'  =>  'Sample Info',
-      'templatefile' =>  'puppi/info.erb',
-      'run'          =>  'myownscript',
-    }
-  }
-
-  describe 'Test puppi info step file creation' do
-    it 'should create a puppi::info step file' do
-      should contain_file('/etc/puppi/info/sample').with_ensure('present')
-    end
-    it 'should populate correctly the puppi::info step file' do
-      should contain_file('/etc/puppi/info/sample').with_content(/myownscript/)
-    end
-  end
-
   on_supported_os.select { |k, _v| k == 'redhat-8-x86_64'  }.each do |os, os_facts|
     context "on #{os}" do
       let(:facts) { os_facts }
-
+      let(:title) { 'puppi::info' }
+      let(:node) { 'rspec.example42.com' }
+      let(:pre_condition) { 'include puppi' }
+      let(:params) {
+        { 'name'         =>  'sample',
+          'description'  =>  'Sample Info',
+          'templatefile' =>  'puppi/info.erb',
+          'run'          =>  'myownscript',
+        }
+      }
+
+      describe 'Test puppi info step file creation' do
+        it 'should create a puppi::info step file' do
+          should contain_file('/etc/puppi/info/sample').with_ensure('present')
+        end
+        it 'should populate correctly the puppi::info step file' do
+          should contain_file('/etc/puppi/info/sample').with_content(/myownscript/)
+        end
+      end
       it { is_expected.to compile }
     end
   end

spec/defines/initialize_spec.rb

@@ -3,22 +3,20 @@
 require 'spec_helper'
 
 describe 'puppi::initialize' do
-  let(:title) { 'puppi::initialize' }
-  let(:node) { 'rspec.example42.com' }
-  let(:pre_condition) { 'include puppi' }
-  let(:params) {
-    { 'enable'   =>  'true',
-      'name'     =>  'get',
-      'command'  =>  'echo',
-      'priority' =>  '50',
-      'project'  =>  'myapp',
-    }
-  }
-
   on_supported_os.select { |k, _v| k == 'redhat-8-x86_64'  }.each do |os, os_facts|
     context "on #{os}" do
       let(:facts) { os_facts }
-
+      let(:title) { 'puppi::initialize' }
+      let(:node) { 'rspec.example42.com' }
+      let(:pre_condition) { 'include puppi' }
+      let(:params) {
+        { 'enable'   =>  'true',
+          'name'     =>  'get',
+          'command'  =>  'echo',
+          'priority' =>  '50',
+          'project'  =>  'myapp',
+        }
+      }
       it { is_expected.to compile }
     end
   end

spec/defines/install_packages_spec.rb

@@ -3,17 +3,15 @@
 require 'spec_helper'
 
 describe 'puppi::install_packages' do
-  let(:title) { 'namevar' }
-  let(:node) { 'rspec.example42.com' }
-  let(:pre_condition) { 'include puppi' }
-  let(:params) do
-    {}
-  end
-
   on_supported_os.select { |k, _v| k == 'redhat-8-x86_64'  }.each do |os, os_facts|
     context "on #{os}" do
       let(:facts) { os_facts }
-
+      let(:title) { 'namevar' }
+      let(:node) { 'rspec.example42.com' }
+      let(:pre_condition) { 'include puppi' }
+      let(:params) do
+        {}
+      end
       it { is_expected.to compile }
     end
   end

spec/defines/log_spec.rb

@@ -3,27 +3,26 @@
 require 'spec_helper'
 
 describe 'puppi::log' do
-  let(:title) { 'mylog' }
-  let(:node) { 'rspec.example42.com' }
-  let(:pre_condition) { 'include puppi' }
-  let(:params) {
-    { 'log'         =>  '/var/log/mylog.log',
-      'description' =>  'My Log',
-    }
-  }
-
-  describe 'Test puppi log file creation' do
-    it 'should create a puppi::log file' do
-      should contain_file('/etc/puppi/logs/mylog').with_ensure('present')
-    end
-    it 'should populate correctly the puppi::log step file' do
-      should contain_file('/etc/puppi/logs/mylog').with_content(/mylog.log/)
-    end
-  end
-
   on_supported_os.select { |k, _v| k == 'redhat-8-x86_64'  }.each do |os, os_facts|
     context "on #{os}" do
       let(:facts) { os_facts }
+      let(:title) { 'mylog' }
+      let(:node) { 'rspec.example42.com' }
+      let(:pre_condition) { 'include puppi' }
+      let(:params) {
+        { 'log'         =>  '/var/log/mylog.log',
+          'description' =>  'My Log',
+        }
+      }
+
+      describe 'Test puppi log file creation' do
+        it 'should create a puppi::log file' do
+          should contain_file('/etc/puppi/logs/mylog').with_ensure('present')
+        end
+        it 'should populate correctly the puppi::log step file' do
+          should contain_file('/etc/puppi/logs/mylog').with_content(/mylog.log/)
+        end
+      end
 
       it { is_expected.to compile }
     end

spec/defines/netinstall_spec.rb

@@ -3,17 +3,15 @@
 require 'spec_helper'
 
 describe 'puppi::netinstall' do
-  let(:title) { 'namevar' }
-  let(:node) { 'rspec.example42.com' }
-  let(:pre_condition) { 'include puppi' }
-  let(:params) do
-    {}
-  end
-
   on_supported_os.select { |k, _v| k == 'redhat-8-x86_64'  }.each do |os, os_facts|
     context "on #{os}" do
       let(:facts) { os_facts }
-
+      let(:title) { 'namevar' }
+      let(:node) { 'rspec.example42.com' }
+      let(:pre_condition) { 'include puppi' }
+      let(:params) do
+        {}
+      end
       it { is_expected.to compile }
     end
   end

spec/defines/project/archive_spec.rb

@@ -4,9 +4,12 @@
 
 describe 'puppi::project::archive' do
   let(:title) { 'namevar' }
-  let(:params) do
-    {}
-  end
+  let(:params) {
+    { 
+      'source'      =>  'test',
+      'deploy_root' => '/tmp',
+    }
+  }
 
   on_supported_os.select { |k, _v| k == 'redhat-8-x86_64'  }.each do |os, os_facts|
     context "on #{os}" do

spec/defines/project/builder_spec.rb

@@ -4,9 +4,13 @@
 
 describe 'puppi::project::builder' do
   let(:title) { 'namevar' }
-  let(:params) do
-    {}
-  end
+  let(:params) {
+    { 
+      'source'      => 'test',
+      'source_type' => 'git',
+      'deploy_root' => '/tmp',
+    }
+  }
 
   on_supported_os.select { |k, _v| k == 'redhat-8-x86_64'  }.each do |os, os_facts|
     context "on #{os}" do

spec/defines/project/dir_spec.rb

@@ -4,9 +4,12 @@
 
 describe 'puppi::project::dir' do
   let(:title) { 'namevar' }
-  let(:params) do
-    {}
-  end
+  let(:params) {
+    { 
+      'source'      => 'test',
+      'deploy_root' => '/tmp',
+    }
+  }
 
   on_supported_os.select { |k, _v| k == 'redhat-8-x86_64'  }.each do |os, os_facts|
     context "on #{os}" do

spec/defines/project/files_spec.rb

@@ -4,9 +4,13 @@
 
 describe 'puppi::project::files' do
   let(:title) { 'namevar' }
-  let(:params) do
-    {}
-  end
+  let(:params) {
+    { 
+      'source'      => 'test',
+      'deploy_root' => '/tmp',
+      'source_baseurl' => 'http://example.com',
+    }
+  }
 
   on_supported_os.select { |k, _v| k == 'redhat-8-x86_64'  }.each do |os, os_facts|
     context "on #{os}" do

spec/defines/project/git_spec.rb

@@ -4,9 +4,12 @@
 
 describe 'puppi::project::git' do
   let(:title) { 'namevar' }
-  let(:params) do
-    {}
-  end
+  let(:params) {
+    { 
+      'source'      => 'test',
+      'deploy_root' => '/tmp',
+    }
+  }
 
   on_supported_os.select { |k, _v| k == 'redhat-8-x86_64'  }.each do |os, os_facts|
     context "on #{os}" do

spec/defines/project/hg_spec.rb

@@ -4,9 +4,12 @@
 
 describe 'puppi::project::hg' do
   let(:title) { 'namevar' }
-  let(:params) do
-    {}
-  end
+  let(:params) {
+    { 
+      'source'      => 'test',
+      'deploy_root' => '/tmp',
+    }
+  }
 
   on_supported_os.select { |k, _v| k == 'redhat-8-x86_64'  }.each do |os, os_facts|
     context "on #{os}" do

spec/defines/project/maven_spec.rb

@@ -4,9 +4,12 @@
 
 describe 'puppi::project::maven' do
   let(:title) { 'namevar' }
-  let(:params) do
-    {}
-  end
+  let(:params) {
+    { 
+      'source'      => 'test',
+      'deploy_root' => '/tmp',
+    }
+  }
 
   on_supported_os.select { |k, _v| k == 'redhat-8-x86_64'  }.each do |os, os_facts|
     context "on #{os}" do

spec/defines/project/mysql_spec.rb

@@ -4,9 +4,12 @@
 
 describe 'puppi::project::mysql' do
   let(:title) { 'namevar' }
-  let(:params) do
-    {}
-  end
+  let(:params) {
+    { 
+      'source'         => 'test',
+      'mysql_database' => 'tmp',
+    }
+  }
 
   on_supported_os.select { |k, _v| k == 'redhat-8-x86_64'  }.each do |os, os_facts|
     context "on #{os}" do

spec/defines/project/svn_spec.rb

@@ -4,9 +4,12 @@
 
 describe 'puppi::project::svn' do
   let(:title) { 'namevar' }
-  let(:params) do
-    {}
-  end
+  let(:params) {
+    { 
+      'source'      => 'test',
+      'deploy_root' => '/tmp',
+    }
+  }
 
   on_supported_os.select { |k, _v| k == 'redhat-8-x86_64'  }.each do |os, os_facts|
     context "on #{os}" do

spec/defines/project/tar_spec.rb

@@ -4,9 +4,12 @@
 
 describe 'puppi::project::tar' do
   let(:title) { 'namevar' }
-  let(:params) do
-    {}
-  end
+  let(:params) {
+    { 
+      'source'      => 'test',
+      'deploy_root' => '/tmp',
+    }
+  }
 
   on_supported_os.select { |k, _v| k == 'redhat-8-x86_64'  }.each do |os, os_facts|
     context "on #{os}" do

spec/defines/project/war_spec.rb

@@ -4,9 +4,12 @@
 
 describe 'puppi::project::war' do
   let(:title) { 'namevar' }
-  let(:params) do
-    {}
-  end
+  let(:params) {
+    { 
+      'source'      => 'test',
+      'deploy_root' => '/tmp',
+    }
+  }
 
   on_supported_os.select { |k, _v| k == 'redhat-8-x86_64'  }.each do |os, os_facts|
     context "on #{os}" do

spec/defines/project/y4maven_spec.rb

@@ -4,9 +4,12 @@
 
 describe 'puppi::project::y4maven' do
   let(:title) { 'namevar' }
-  let(:params) do
-    {}
-  end
+  let(:params) {
+    { 
+      'source'      => 'test',
+      'deploy_root' => '/tmp',
+    }
+  }
 
   on_supported_os.select { |k, _v| k == 'redhat-8-x86_64'  }.each do |os, os_facts|
     context "on #{os}" do

spec/defines/project/yum_spec.rb

@@ -4,9 +4,11 @@
 
 describe 'puppi::project::yum' do
   let(:title) { 'namevar' }
-  let(:params) do
-    {}
-  end
+  let(:params) {
+    { 
+      'rpm'      => 'test',
+    }
+  }
 
   on_supported_os.select { |k, _v| k == 'redhat-8-x86_64'  }.each do |os, os_facts|
     context "on #{os}" do

spec/defines/project_spec.rb

@@ -3,30 +3,29 @@
 require 'spec_helper'
 
 describe 'puppi::project' do
-  let(:title) { 'puppi::project' }
-  let(:node) { 'rspec.example42.com' }
-  let(:pre_condition) { 'include puppi' }
-  let(:params) {
-    { 'enable'   =>  'true',
-      'name'     =>  'get',
-      'command'  =>  'echo',
-      'priority' =>  '50',
-      'project'  =>  'myapp',
-    }
-  }
-
-  describe 'Test puppi report step file creation' do
-    it 'should create a puppi::report step file' do
-      should contain_file('/etc/puppi/projects/myapp/report/50-get').with_ensure('present')
-    end
-    it 'should populate correctly the puppi::report step file' do
-      should contain_file('/etc/puppi/projects/myapp/report/50-get').with_content("su - root -c \"export project=myapp && /etc/puppi/scripts/echo \"\n")
-    end
-  end
-
   on_supported_os.select { |k, _v| k == 'redhat-8-x86_64'  }.each do |os, os_facts|
     context "on #{os}" do
       let(:facts) { os_facts }
+      let(:title) { 'puppi::project' }
+      let(:node) { 'rspec.example42.com' }
+      let(:pre_condition) { 'include puppi' }
+      let(:params) {
+        { 'enable'   =>  'true',
+          'name'     =>  'get',
+          'command'  =>  'echo',
+          'priority' =>  '50',
+          'project'  =>  'myapp',
+        }
+      }
+
+      describe 'Test puppi report step file creation' do
+        it 'should create a puppi::report step file' do
+          should contain_file('/etc/puppi/projects/myapp/report/50-get').with_ensure('present')
+        end
+        it 'should populate correctly the puppi::report step file' do
+          should contain_file('/etc/puppi/projects/myapp/report/50-get').with_content("su - root -c \"export project=myapp && /etc/puppi/scripts/echo \"\n")
+        end
+      end
 
       it { is_expected.to compile }
     end

spec/defines/report_spec.rb

@@ -3,31 +3,30 @@
 require 'spec_helper'
 
 describe 'puppi::report' do
-  let(:title) { 'puppi::report' }
-  let(:node) { 'rspec.example42.com' }
-  let(:pre_condition) { 'include puppi' }
-  let(:params) {
-    { 'enable'   =>  'true',
-      'name'     =>  'get',
-      'command'  =>  'echo',
-      'priority' =>  '50',
-      'project'  =>  'myapp',
-    }
-  }
-
-  describe 'Test puppi report step file creation' do
-    it 'should create a puppi::report step file' do
-      should contain_file('/etc/puppi/projects/myapp/report/50-get').with_ensure('present')
-    end
-    it 'should populate correctly the puppi::report step file' do
-      should contain_file('/etc/puppi/projects/myapp/report/50-get').with_content("su - root -c \"export project=myapp && /etc/puppi/scripts/echo \"\n")
-    end
-  end
-
   on_supported_os.select { |k, _v| k == 'redhat-8-x86_64'  }.each do |os, os_facts|
     context "on #{os}" do
       let(:facts) { os_facts }
-
+      let(:title) { 'puppi::report' }
+      let(:node) { 'rspec.example42.com' }
+      let(:pre_condition) { 'include puppi' }
+      let(:params) {
+        { 'enable'   =>  'true',
+          'name'     =>  'get',
+          'command'  =>  'echo',
+          'priority' =>  '50',
+          'project'  =>  'myapp',
+        }
+      }
+
+      describe 'Test puppi report step file creation' do
+        it 'should create a puppi::report step file' do
+          should contain_file('/etc/puppi/projects/myapp/report/50-get').with_ensure('present')
+        end
+        it 'should populate correctly the puppi::report step file' do
+          should contain_file('/etc/puppi/projects/myapp/report/50-get').with_content("su - root -c \"export project=myapp && /etc/puppi/scripts/echo \"\n")
+        end
+      end
+
       it { is_expected.to compile }
     end
   end

spec/defines/rollback_spec.rb

@@ -3,30 +3,29 @@
 require 'spec_helper'
 
 describe 'puppi::rollback' do
-  let(:title) { 'puppi::rollback' }
-  let(:node) { 'rspec.example42.com' }
-  let(:pre_condition) { 'include puppi' }
-  let(:params) {
-    { 'enable'   =>  'true',
-      'name'     =>  'get',
-      'command'  =>  'echo',
-      'priority' =>  '50',
-      'project'  =>  'myapp',
-    }
-  }
-
-  describe 'Test puppi rollback step file creation' do
-    it 'should create a puppi::rollback step file' do
-      should contain_file('/etc/puppi/projects/myapp/rollback/50-get').with_ensure('present')
-    end
-    it 'should populate correctly the puppi::rollback step file' do
-      should contain_file('/etc/puppi/projects/myapp/rollback/50-get').with_content("su - root -c \"export project=myapp && /etc/puppi/scripts/echo \"\n")
-    end
-  end
-
   on_supported_os.select { |k, _v| k == 'redhat-8-x86_64'  }.each do |os, os_facts|
     context "on #{os}" do
       let(:facts) { os_facts }
+      let(:title) { 'puppi::rollback' }
+      let(:node) { 'rspec.example42.com' }
+      let(:pre_condition) { 'include puppi' }
+      let(:params) {
+        { 'enable'   =>  'true',
+          'name'     =>  'get',
+          'command'  =>  'echo',
+          'priority' =>  '50',
+          'project'  =>  'myapp',
+        }
+      }
+
+      describe 'Test puppi rollback step file creation' do
+        it 'should create a puppi::rollback step file' do
+          should contain_file('/etc/puppi/projects/myapp/rollback/50-get').with_ensure('present')
+        end
+        it 'should populate correctly the puppi::rollback step file' do
+          should contain_file('/etc/puppi/projects/myapp/rollback/50-get').with_content("su - root -c \"export project=myapp && /etc/puppi/scripts/echo \"\n")
+        end
+      end
 
       it { is_expected.to compile }
     end

spec/defines/run_spec.rb

@@ -3,22 +3,21 @@
 require 'spec_helper'
 
 describe 'puppi::run' do
-  let(:title) { 'myapp' }
-  let(:node) { 'rspec.example42.com' }
-  let(:pre_condition) { 'include puppi' }
-  let(:params) {
-    { 
-      'project'  =>  'myapp',
-    }
-  }
-
-  describe 'Test puppi run exe creation' do
-    it { should contain_exec('Run_Puppi_myapp').with_command(/puppi deploy myapp/) }
-  end
-
   on_supported_os.select { |k, _v| k == 'redhat-8-x86_64'  }.each do |os, os_facts|
     context "on #{os}" do
       let(:facts) { os_facts }
+      let(:title) { 'myapp' }
+      let(:node) { 'rspec.example42.com' }
+      let(:pre_condition) { 'include puppi' }
+      let(:params) {
+        { 
+          'project'  =>  'myapp',
+        }
+      }
+
+      describe 'Test puppi run exe creation' do
+        it { should contain_exec('Run_Puppi_myapp').with_command(/puppi deploy myapp/) }
+      end
 
       it { is_expected.to compile }
     end

spec/defines/runscript_spec.rb

@@ -3,16 +3,15 @@
 require 'spec_helper'
 
 describe 'puppi::runscript' do
-  let(:title) { 'namevar' }
-  let(:node) { 'rspec.example42.com' }
-  let(:pre_condition) { 'include puppi' }
-  let(:params) do
-    {}
-  end
-
   on_supported_os.select { |k, _v| k == 'redhat-8-x86_64'  }.each do |os, os_facts|
     context "on #{os}" do
       let(:facts) { os_facts }
+      let(:title) { 'namevar' }
+      let(:node) { 'rspec.example42.com' }
+      let(:pre_condition) { 'include puppi' }
+      let(:params) do
+        {}
+      end
 
       it { is_expected.to compile }
     end

spec/defines/todo_spec.rb

@@ -3,30 +3,29 @@
 require 'spec_helper'
 
 describe 'puppi::todo' do
-  let(:title) { 'mytodo' }
-  let(:node) { 'rspec.example42.com' }
-  let(:pre_condition) { 'include puppi' }
-  let(:params) {
-    { 'notes'         =>  'Test Notes',
-      'description'   =>  'Test Description',
-      'check_command' =>  'check_test',
-      'run'           =>  'test',
-    }
-  }
-
-  describe 'Test puppi todo file creation' do
-    it 'should create a puppi::todo file' do
-      should contain_file('/etc/puppi/todo/mytodo').with_ensure('present')
-    end
-    it 'should populate correctly the puppi::todo step file' do
-      should contain_file('/etc/puppi/todo/mytodo').with_content(/check_test/)
-    end
-  end
-
   on_supported_os.select { |k, _v| k == 'redhat-8-x86_64'  }.each do |os, os_facts|
     context "on #{os}" do
       let(:facts) { os_facts }
-
+      let(:title) { 'mytodo' }
+      let(:node) { 'rspec.example42.com' }
+      let(:pre_condition) { 'include puppi' }
+      let(:params) {
+        { 'notes'         =>  'Test Notes',
+          'description'   =>  'Test Description',
+          'check_command' =>  'check_test',
+          'run'           =>  'test',
+        }
+      }
+
+      describe 'Test puppi todo file creation' do
+        it 'should create a puppi::todo file' do
+          should contain_file('/etc/puppi/todo/mytodo').with_ensure('present')
+        end
+        it 'should populate correctly the puppi::todo step file' do
+          should contain_file('/etc/puppi/todo/mytodo').with_content(/check_test/)
+        end
+      end
+
       it { is_expected.to compile }
     end
   end

spec/defines/ze_spec.rb

@@ -3,26 +3,25 @@
 require 'spec_helper'
 
 describe 'puppi::ze' do
-  let(:title) { 'sample' }
-  let(:node) { 'rspec.example42.com' }
-  let(:pre_condition) { 'include puppi' }
-  let(:params) {
-    { 'helper'     => 'mytest',
-      'variables'  => { 'var1' => 'get', 'var2' => 'got' },
-      'name'       => 'sample',
-    }
-  }
-
-  describe 'Test puppi ze data file creation' do
-    it 'should create a puppi::ze step file' do
-      should contain_file('puppize_sample').with_ensure('present')
-    end
-  end
-
   on_supported_os.select { |k, _v| k == 'redhat-8-x86_64'  }.each do |os, os_facts|
     context "on #{os}" do
       let(:facts) { os_facts }
-
+      let(:title) { 'sample' }
+      let(:node) { 'rspec.example42.com' }
+      let(:pre_condition) { 'include puppi' }
+      let(:params) {
+        { 'helper'     => 'mytest',
+          'variables'  => { 'var1' => 'get', 'var2' => 'got' },
+          'name'       => 'sample',
+        }
+      }
+
+      describe 'Test puppi ze data file creation' do
+        it 'should create a puppi::ze step file' do
+          should contain_file('puppize_sample').with_ensure('present')
+        end
+      end
+
       it { is_expected.to compile }
     end
   end