Open
Conversation
evmar
added a commit
that referenced
this pull request
Jan 10, 2026
Could be useful for the PR #139.
Owner
|
I just pushed a little README with how I write tests for these kinds of things, in case you want to try it. I'm also fine with merging this as is if you like though. Reading https://en.wikipedia.org/wiki/Intel_BCD_opcodes (never really worked with BCD), the only thing I notice is the mention of the special "indefinite" value. It might be worth adding a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documentation: https://www.felixcloutier.com/x86/fbld
and I've tried my best to verify it against the documentation, but at the end of the day I don't have a great way to verify that the implementation is 100% correct 😅
I also tried finding any bcd functions built into Rust, that would actually emit code that uses this instruction (e.g.
f64::from_bcd([u8; 10])would have been nice 😁) but couldn't find any. So this contains code to actually do the BCD decoding.Maybe this is not desirable? I'm very open to any other approaches!
Also, if you want me to do any changes to the code I'm happy to, it's a bit "chatty" now with the comments? But it did help me understand what's going on...
I'm also wondering if upping the multipler for each iteration is the way to go, or multiplying the result by 10 every time would be better 🤔