Refactor path handling in useEffect for improved navigation state man… #624
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…agement in NavigationItem.jsx ## Refactor path handling in useEffect for improved navigation state management - Replaced complex URL parsing logic with simpler pathname checks. - Converted from checking `window.location.href` and `window.location.origin` to using `window.location.pathname` for cleaner path management. - Added handling for special paths like '/admin/products/new', '/admin/coupon/new', and '/admin' to set active state based on exact path matches. - Enhanced logic to ensure correct navigation item activation based on current path, handling cases where new items should be activated rather than general categories. Changes: - Simplified path comparison and activation logic. - Addressed specific cases for 'new' items to ensure correct active state management.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…agement in NavigationItem.jsx
Refactor path handling in useEffect for improved navigation state management
window.location.hrefandwindow.location.originto usingwindow.location.pathnamefor cleaner path management.Changes:
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
When I click 'New Product', the navigation item does not become active (The 'Product' item is active instead of 'New Product'.). However, when I click 'New Coupon', the navigation item becomes active as expected.
product
coupon
Issue Number: N/A
What is the new behavior?
I fixed the issue, and now 'Product' behaves the same way as 'New Coupon'—the navigation item becomes active as expected.
Does this PR introduce a breaking change?
Other information