fix(snapshot): account function source bytes#1837
Merged
Merged
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
bashkit | 89bc3c0 | Commit Preview URL | Jun 02 2026, 09:35 AM |
3bd038c to
89bc3c0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
FunctionDef.sourcewithout charging againstMemoryLimits::max_function_body_bytes, which allowed resource-exhaustion via many large function sources.Description
input.len()by usingcurrent_span.end.offsetat EOF inParser::current_command_end_offsetso skipped trailing comments aren't included in captured source (crates/bashkit/src/parser/mod.rs).function_storage_bytes(func: &FunctionDef)to charge storedFunctionDef.sourcebytes when present and fall back to ASTspansize for legacy cases (crates/bashkit/src/interpreter/mod.rs).function_storage_byteswhen enforcing function insert/replace budgets at runtime and during snapshot restore and budget recompute so stored source is accounted for (crates/bashkit/src/interpreter/mod.rs).max_function_body_bytes(crates/bashkit/tests/integration/snapshot_tests.rs).Testing
snapshot_function_source_excludes_trailing_eof_commentandsnapshot_restore_counts_source_bytes_against_function_limitand both passed.cargo test -p bashkit --test integration snapshot_tests::and all snapshot tests passed (40 passed, 0 failed).cargo fmt --checkandcargo clippy -p bashkit --tests -- -D warningsas formatting/lint checks and they succeeded.Codex Task