fix(snapshot): preserve counters on resume#1835
Merged
chaliy merged 1 commit intoJun 2, 2026
Merged
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
bashkit | d3db6d8 | Commit Preview URL | Jun 02 2026, 09:33 AM |
044750b to
d3db6d8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
restore_session_countersfromrestore_snapshot_innerafter validated shell/VFS restore so counters are applied atomically with state.Interpreter::restore_session_countersto be monotonic (usemax) so restoring never reduces already-consumedsession_commandsorsession_exec_calls.Bash::restore_session_countersdocstring to reflect monotonic merge semantics.keyed_snapshot_restore_carries_session_exec_budget_forwardandfrom_snapshot_keyed_restores_session_countersto assert authenticated resumes carry counters forward.Testing
cargo test -p bashkit --test integration snapshot_tests:: -- --nocaptureand all snapshot-related tests passed (40 passed, 0 failed).cargo fmt --all -- --checkto ensure formatting is clean and it passed.Codex Task