fix(scripted-tool): isolate extension invocation traces#1832
Open
chaliy wants to merge 1 commit into
Open
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
bashkit | 3b82ecd | Commit Preview URL | Jun 02 2026, 09:31 AM |
3c130e6 to
3b82ecd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Arc<Mutex<...>>invocation log that could mix raw argv across builds/clones.Description
ToolDefExtension::clone()allocate a fresh invocation log so clones do not share trace state.ToolDefInvocationTrace(withtake_invocations) andToolDefExtension::invocation_trace()to provide an explicit, intentional trace handle that can be cloned to share traces when desired.ToolDefExtension::take_invocations()to forward to the explicit trace handle and updateToolDefExtensionBuilder::build()docs to document the isolation contract.ToolDefInvocationTracefrom thescripted_toolmodule and crate root, update tests to useinvocation_trace(), and updatespecs/scripted-tool-orchestration.mdto document the new behavior.Testing
cargo test -p bashkit scripted_tool::tests::test_tool_def_extension --features scripted_tooland all scripted-tool tests in that group passed (5 passed, 0 failed).cargo fmt --checkandgit diff --checkwith no reported issues.crates/bashkit/src/scripted_tool/mod.rsto assert per-build and per-clone isolation and to verify bounded/truncated invocation storage, and those tests passed.Codex Task