fix(interpreter): bound arithmetic variable expansion#1828
Open
chaliy wants to merge 1 commit into
Open
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
bashkit | 61719fd | Commit Preview URL | Jun 02 2026, 09:29 AM |
09e5799 to
61719fd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
ArithmeticExpansionStateto track active variable names and a sharedfuelbudget for a single arithmetic evaluation session.MAX_ARITHMETIC_EXPANSION_FUELandMAX_ARITHMETIC_EXPANSION_BYTESand short-circuit expansion when fuel or generated bytes are exhausted.statethrough arithmetic evaluation paths (evaluate_arithmetic_depth_state,expand_arithmetic_vars_depth_state,resolve_arith_var,expand_brace_expr_in_arithmetic) so nestedarr[index]and brace/index evaluations share depth/fuel.enter_var/exit_varand return0for recursive cycles; addresolve_arith_named_varhelper to do this safely.a='a+a'; echo $((a))andarr[0]=1; i='arr[i]'; echo $((arr[i]))and update the TM-DOS-026 threat-model notes.Testing
cargo fmt --checkwhich passed.cargo test -p bashkitfor the added tests which passed.cargo clippy -p bashkit --all-targets -- -D warningswhich completed without warnings.Codex Task