Skip to content

fix(ci): scope Doppler token to secret fetch steps#1826

Merged
chaliy merged 1 commit into
mainfrom
2026-06-02-fix-doppler-token-exposure-in-workflows
Jun 2, 2026
Merged

fix(ci): scope Doppler token to secret fetch steps#1826
chaliy merged 1 commit into
mainfrom
2026-06-02-fix-doppler-token-exposure-in-workflows

Conversation

@chaliy
Copy link
Copy Markdown
Contributor

@chaliy chaliy commented Jun 2, 2026

Motivation

  • Workflows placed DOPPLER_TOKEN in top-level env, exposing the secret to pnpm install, builds, tests and example runs.
  • Limit secret exposure to only the trusted steps that need it (Doppler CLI / secret-fetch) to prevent exfiltration via lifecycle scripts or PR-controlled JS code.

Description

  • Removed workflow-level DOPPLER_TOKEN from .github/workflows/js.yml and .github/workflows/publish-js.yml.
  • Added a lightweight detection step (id: doppler) that sets steps.doppler.outputs.available without placing the token into the global process env.
  • Scoped DOPPLER_TOKEN: ${{ secrets.DOPPLER_TOKEN }} only on the Doppler CLI install and AI example secret-fetch steps so npm installs, builds and tests no longer inherit the secret.

Testing

  • Ran a Python static check to confirm no top-level DOPPLER_TOKEN remains and that scoped DOPPLER_TOKEN entries appear only on Doppler steps (python3 script). (passed)
  • Parsed both edited workflow files with Ruby YAML loader to validate syntax (ruby -e 'require "yaml"; ...'). (passed)
  • Linted workflows with actionlint after edits to ensure workflow correctness. (passed)

Codex Task

@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented Jun 2, 2026

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
bashkit b0b1022 Commit Preview URL Jun 02 2026, 09:27 AM

@chaliy chaliy force-pushed the 2026-06-02-fix-doppler-token-exposure-in-workflows branch from 12a603d to b0b1022 Compare June 2, 2026 09:19
@chaliy chaliy merged commit 62bb684 into main Jun 2, 2026
26 checks passed
@chaliy chaliy deleted the 2026-06-02-fix-doppler-token-exposure-in-workflows branch June 2, 2026 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant