fix(ci): validate CLI release tag input#1819
Open
chaliy wants to merge 1 commit into
Open
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
bashkit | 98ef06a | Commit Preview URL | Jun 02 2026, 09:23 AM |
42ccfba to
98ef06a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
workflow_dispatchtaginput in.github/workflows/cli-binaries.ymlwas interpolated directly into shellrun:blocks and used as theactions/checkoutref, allowing command injection and secret exposure when run with write-scoped tokens.Description
validate-tagjob that validatesinputs.tagagainst the regex^v[0-9]+\.[0-9]+\.[0-9]+$and publishes the validated value as a job output for downstream jobs to consume.permissionstocontents: read, and keepcontents: writeonly on thebuildjob that uploads release artifacts.builddepend onvalidate-tag, changeactions/checkoutto useref: ${{ needs.validate-tag.outputs.tag }}and setpersist-credentials: falseto avoid exposing checkout credentials to untrusted refs.${{ inputs.tag }}interpolations inrun:blocks with an explicitRELEASE_TAG/TAGenvironment variable derived from the validated job output, and makeupdate-homebrewdepend on bothvalidate-tagandbuild.Testing
YAML.load_fileto ensure valid YAML, and the parser succeeded. (passed)actionlintviago run github.com/rhysd/actionlint/cmd/actionlint@latest .github/workflows/cli-binaries.ymlto validate Actions semantics. (passed)${{ inputs.tag }}usages were removed and outputs/env usage is present. (passed)v1.2.3$(...)). (passed)Codex Task