-
-
Notifications
You must be signed in to change notification settings - Fork 899
Switch to 15m slots for tariffs and planner #21162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Maschga
wants to merge
16
commits into
evcc-io:master
Choose a base branch
from
Maschga:feat/15m-tariff
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+264
−116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'd say the value is always |
Wie besprochen schaue ich mir die Visualisierung des Ladeplans an. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR is to change default 1h slots to 15m slots. This affects:
We should do this in a way that all internal data structures use 15m slots. For this purpose, tariff data must be converted to 15m slots when received.
We should still supported 1h or 30m tariffs and templates, but provide an option to convert after receive. The output of
evcc tariff
might potentially be simplified to still show 1h slots where applicable (nice to have).When we support 1h or 30m inputs, we'll need specific logic for converting them into 15m slots depending on tariff type:
Planner depends on tariffs and must be changed in the same step since planner assumes 1h slots.
/cc @naltatis can we please align on co2