Skip to content

chore: Typescript: Rewrite Sessions #21047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Jun 2, 2025
Merged

Conversation

Maschga
Copy link
Contributor

@Maschga Maschga commented May 4, 2025

  • ✍️ rewrite Sessions folder to Typescript

TODO:

@naltatis naltatis added the infrastructure Basic functionality label May 5, 2025
@naltatis naltatis self-assigned this May 5, 2025
@Maschga Maschga changed the title Chore: Typescript: Rewrite Sessions chore: Typescript: Rewrite Sessions May 5, 2025
@github-actions github-actions bot added the stale Outdated and ready to close label May 12, 2025
@github-actions github-actions bot removed the stale Outdated and ready to close label May 14, 2025
@naltatis naltatis marked this pull request as ready for review June 2, 2025 22:27
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Maschga - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟡 General issues: 2 issues found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟡 Complexity: 1 issue found
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@naltatis naltatis merged commit 1b1f637 into evcc-io:master Jun 2, 2025
6 checks passed
@Maschga Maschga deleted the tsc/sessions branch June 3, 2025 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Basic functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants