-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add undefined to records typespec #1
base: proto3
Are you sure you want to change the base?
Conversation
src/gpb_compile.erl
Outdated
Defs, Opts) -> | ||
OrUndefined = case get_mapping_and_unset_by_opts(Opts) of | ||
records -> | ||
case gpb:is_msg_proto3(MsgName, Defs) of | ||
true -> ""; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think that this actually does what we want. Could you paste an example of the warning that you're trying to fix?
It generates
The It should look like this:
|
OK, I see what you mean. I still don't think that your fix does the right thing. I'll add it to the list of stuff to fix when I finally get back to trying to get this merged upstream. |
I think this fixes the dialyzer issues, but I can't tell for sure. Referencing a fork of a fork to test it in Nucleus is a pain.