Fix 500 error that occurred when no fields changed - #994
Open
U-238 wants to merge 1 commit into
Open
Conversation
Owner
|
Sorry, I just noticed this pr 😮 Can you provide a traceback for the error this fixes? It would be good to verify that this fixes the problem before merging it blind 😄 |
Author
|
Hi @etianen, no problem. I've just confirmed the bug still exists in django-reversion 6.3.0, running on Python 3.12 with Django 6.0.6. Here is the stack trace: Then I tried applying the same fix as in this PR, and the bug no longer occurred. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using Django 6.0 and django-reversion 6.1.0, I was getting a 500 error when saving a model where no fields had changed. This PR fixes this bug.