Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PRO-2501-Arka_Contract_Events_Whitelist #123

Merged
merged 3 commits into from
Aug 12, 2024
Merged

PRO-2501-Arka_Contract_Events_Whitelist #123

merged 3 commits into from
Aug 12, 2024

Conversation

vignesha22
Copy link
Contributor

Description

  • Added a new table for Contract whitelisting based on the sponsor wallet address
  • Added new env var for EPv07 token paymasters VGL and PGL
  • Added migrations as modicifactions are done on apiKeys to include another column for enabling contract whitelisting

Types of changes

What types of changes does your code introduce?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Other (please describe):

Further comments (optional)

@linear Linear
Copy link

linear bot commented Aug 9, 2024

PRO-2501 Arka: Whitelist sponsorship for specific operations

ch4r10t33r
ch4r10t33r requested changes Aug 9, 2024
View reviewed changes
Copy link
Member

@ch4r10t33r ch4r10t33r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have we shortlisted the list of contract addresses which we intend to preload to the hosted setup? Will this be included in this PR?

backend/migrations/2024080800001-create-contract-whitelist.cjs Outdated Show resolved Hide resolved
backend/src/models/contract-whitelist.ts Outdated Show resolved Hide resolved
backend/src/routes/whitelist-routes.ts Outdated Show resolved Hide resolved
backend/src/routes/whitelist-routes.ts Outdated Show resolved Hide resolved
backend/src/routes/whitelist-routes.ts Outdated Show resolved Hide resolved
backend/src/types/contractWhitelist-dto.ts Outdated Show resolved Hide resolved
@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Aug 9, 2024 •
edited
Loading

Deploying arka with  Cloudflare Pages  Cloudflare Pages

Latest commit: 57e7b85
Status: ✅  Deploy successful!
Preview URL: https://f0a42552.arka-3qg.pages.dev
Branch Preview URL: https://pro-2501-arka-contract-event.arka-3qg.pages.dev

View logs

ch4r10t33r
ch4r10t33r approved these changes Aug 9, 2024
View reviewed changes
Copy link
Member

@ch4r10t33r ch4r10t33r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vignesha22 vignesha22 merged commit 9a796de into master Aug 12, 2024
4 checks passed
@vignesha22 vignesha22 deleted the PRO-2501-Arka_Contract_Events_Whitelist branch August 12, 2024 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kanthgithub kanthgithub kanthgithub approved these changes

@ch4r10t33r ch4r10t33r ch4r10t33r approved these changes

@0xSulpiride 0xSulpiride Awaiting requested review from 0xSulpiride

@cryptonoyaiba cryptonoyaiba Awaiting requested review from cryptonoyaiba

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vignesha22 @ch4r10t33r @kanthgithub