Fix Failing Save after Attempted Delete of Non-Existent Key (#29)#30
Open
brainiac-five wants to merge 2 commits intomasterfrom
Open
Fix Failing Save after Attempted Delete of Non-Existent Key (#29)#30brainiac-five wants to merge 2 commits intomasterfrom
brainiac-five wants to merge 2 commits intomasterfrom
Conversation
failing save after attempted deletion of non-existing key pair
brainiac-five
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix of failing save after attempt of deletion of non-existent key.
This PR makes PR #27 obsolete. The regression tests of #27 are also passing with the change of this PR:
proximity-order-trie/pkg/elements/mode.go
Lines 132 to 135 in 14e79fd
The approach in this PR tolerates nil being returned from
ops Update()and prevents it from ending up in root at the above line. This catches two other cases inops Update()beyond the one fixed in PR #27.Note that the regression tests of #27 are not included in this PR to avoid confusion.