Skip to content

Fix matching updates (#26) #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
brainiac-five wants to merge 1 commit into from
Closed

Fix matching updates (#26) #27

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
64 changes: 64 additions & 0 deletions kvs_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,70 @@ func TestPotKvs_Save(t *testing.T) {
assert.NoError(t, err)
assert.True(t, len(ref) > 0)
})
t.Run("Put key-value pair a second time, then save", func(t *testing.T) {
s, _ := pot.NewSwarmKvs(ls)
err := s.Put(ctx, key1, val1)
assert.NoError(t, err)
err = s.Put(ctx, key1, val1)
assert.NoError(t, err)
_, err = s.Save(ctx)
assert.NoError(t, err)
})
t.Run("Save twice", func(t *testing.T) {
s, _ := pot.NewSwarmKvs(ls)
err := s.Put(ctx, key1, val1)
assert.NoError(t, err)
_, err = s.Save(ctx)
assert.NoError(t, err)
_, err = s.Save(ctx)
assert.NoError(t, err)
})
t.Run("Change key's value between two saves", func(t *testing.T) {
s, _ := pot.NewSwarmKvs(ls)
err := s.Put(ctx, key1, val1)
assert.NoError(t, err)
_, err = s.Save(ctx)
assert.NoError(t, err)
err = s.Put(ctx, key1, val2)
assert.NoError(t, err)
_, err = s.Save(ctx)
assert.NoError(t, err)
})
t.Run("Store same value under different key between two saves", func(t *testing.T) {
s, _ := pot.NewSwarmKvs(ls)
err := s.Put(ctx, key1, val1)
assert.NoError(t, err)
_, err = s.Save(ctx)
assert.NoError(t, err)
err = s.Put(ctx, key2, val1)
assert.NoError(t, err)
_, err = s.Save(ctx)
assert.NoError(t, err)
})
t.Run("Put same key-value pair a second time between saves", func(t *testing.T) {
s, _ := pot.NewSwarmKvs(ls)
err := s.Put(ctx, key1, val1)
assert.NoError(t, err)
_, err = s.Save(ctx)
assert.NoError(t, err)
err = s.Put(ctx, key1, val1)
assert.NoError(t, err)
_, err = s.Save(ctx)
assert.NoError(t, err)
})
t.Run("Put same key-value pair a second time, on new-by-reference KVS, between saves", func(t *testing.T) {
s, _ := pot.NewSwarmKvs(ls)
err := s.Put(ctx, key1, val1)
assert.NoError(t, err)
ref, err := s.Save(ctx)
assert.NoError(t, err)
s2, err := pot.NewSwarmKvsReference(ctx, ls, ref)
assert.NoError(t, err)
err = s2.Put(ctx, key1, val1)
assert.NoError(t, err)
_, err = s2.Save(ctx)
assert.NoError(t, err)
})
t.Run("Save KVS with one item, no error, pre-save value exist", func(t *testing.T) {
s1, _ := pot.NewSwarmKvs(ls)

Expand Down
2 changes: 1 addition & 1 deletion pkg/elements/ops.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ func update(ctx context.Context, acc Node, cn CNode, k []byte, entry *Entry, mod
}
orig := cn.Node.Entry()
if (*entry).Equal(orig) {
return nil, nil
return cn.Node, nil
}
n := mode.New()
n.Pin(*entry)
Expand Down