crypto/bn256: fix G2.Neg setting e.z to a.z - #35660
Closed
fumin wants to merge 1 commit into
Closed
Conversation
fumin
changed the title
This was found by testing against test_pairing_negative_G2 from py_ecc https://github.com/ethereum/py_ecc/blob/v8.0.0/tests/core/test_bn128_and_bls12_381.py#L296
fumin
force-pushed
the
fix_pair_negative_g2
branch
from
September 5, 2026 19:15
62829d9 to
0c2bea5
Compare
Member
|
Please open these PRs against the upstream repo. BN256 is a vendored in dependency that we don't want to change manually in our codebase |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was found by testing against test_pairing_negative_G2 from py_ecc https://github.com/ethereum/py_ecc/blob/v8.0.0/tests/core/test_bn128_and_bls12_381.py#L296
Fixes #35661