Skip to content

Conversation

@felix314159
Copy link
Contributor

@felix314159 felix314159 commented Nov 28, 2025

πŸ—’οΈ Description

Please ensure that the modexp cases correct like this, it seems to work on Sepolia.

Edit: @spencer-tb validated all updated tests on Hoodi.

πŸ”— Related Issues or PRs

N/A.

βœ… Checklist

  • All: Ran fast tox checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:
    uvx tox -e static
  • All: PR title adheres to the repo standard - it will be used as the squash commit message and should start type(scope):.
  • All: Considered adding an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • All: Set appropriate labels for the changes (only maintainers can apply labels).

@codecov
Copy link

codecov bot commented Nov 28, 2025

Codecov Report

βœ… All modified and coverable lines are covered by tests.
βœ… Project coverage is 87.31%. Comparing base (f23e4ab) to head (0ed6103).
⚠️ Report is 13 commits behind head on forks/osaka.

Additional details and impacted files
@@               Coverage Diff               @@
##           forks/osaka    #1820      +/-   ##
===============================================
+ Coverage        86.08%   87.31%   +1.23%     
===============================================
  Files              743      541     -202     
  Lines            44076    32832   -11244     
  Branches          3891     3015     -876     
===============================================
- Hits             37941    28668    -9273     
+ Misses            5657     3557    -2100     
- Partials           478      607     +129     
Flag Coverage Ξ”
unittests 87.31% <ΓΈ> (+1.23%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

πŸš€ New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • πŸ“¦ JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@spencer-tb spencer-tb added C-enhance Category: an improvement or new feature A-test-tests Area: tests for execution spec tests A-test-execution Area: execution spec tests execution package labels Dec 2, 2025
@spencer-tb spencer-tb changed the title feat(tests): added more mainnet tests enhance(test-tests): more execute mainnet marked tests Dec 2, 2025
Copy link
Contributor

@spencer-tb spencer-tb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated. Added more tests. Approved from my side. LGTM.

@marioevz
Copy link
Member

marioevz commented Dec 3, 2025

Reviewing now, pls don't merge.

Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nit comments but overall I think it looks great, thanks!

Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@marioevz marioevz merged commit e5298b7 into ethereum:forks/osaka Dec 3, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-test-execution Area: execution spec tests execution package A-test-tests Area: tests for execution spec tests C-enhance Category: an improvement or new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants