-
Notifications
You must be signed in to change notification settings - Fork 389
enhance(test-tests): more execute mainnet marked tests #1820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance(test-tests): more execute mainnet marked tests #1820
Conversation
Codecov Reportβ
All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## forks/osaka #1820 +/- ##
===============================================
+ Coverage 86.08% 87.31% +1.23%
===============================================
Files 743 541 -202
Lines 44076 32832 -11244
Branches 3891 3015 -876
===============================================
- Hits 37941 28668 -9273
+ Misses 5657 3557 -2100
- Partials 478 607 +129
Flags with carried forward coverage won't be shown. Click here to find out more. β View full report in Codecov by Sentry. π New features to boost your workflow:
|
spencer-tb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated. Added more tests. Approved from my side. LGTM.
|
Reviewing now, pls don't merge. |
marioevz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some nit comments but overall I think it looks great, thanks!
marioevz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
ποΈ Description
Please ensure that the modexp cases correct like this, it seems to work on Sepolia.
Edit: @spencer-tb validated all updated tests on Hoodi.
π Related Issues or PRs
N/A.
β Checklist
toxchecks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:uvx tox -e statictype(scope):.